fixes #118 - removed unneeded test and simplified null parsing

Author: timofriedlbabelforce

src/languageservice/parser/yamlParser07.ts

@@ -115,15 +115,9 @@ function recursivelyBuildAst(parent: ASTNode, node: Yaml.YAMLNode): ASTNode {
                 return new BooleanASTNodeImpl(parent, parseYamlBoolean(value), node.startPosition, node.endPosition - node.startPosition);
             }
 
-            //This is patch to support YAML null values: https://yaml.org/type/null.html
-            const possibleNullValues = ['~', 'NULL', 'Null', 'null'];
-            if (instance.plainScalar && possibleNullValues.indexOf(value.toString()) !== -1) {
-                return new NullASTNodeImpl(parent, node.startPosition, node.endPosition - node.startPosition);
-            }
-
             switch (type) {
                 case Yaml.ScalarType.null: {
-                    return new StringASTNodeImpl(parent, instance.startPosition, instance.endPosition - instance.startPosition);
+                    return new NullASTNodeImpl(parent, node.startPosition, node.endPosition - node.startPosition);
                 }
                 case Yaml.ScalarType.bool: {
                     return new BooleanASTNodeImpl(parent, Yaml.parseYamlBoolean(value), node.startPosition, node.endPosition - node.startPosition);

test/schemaValidation.test.ts

@@ -96,16 +96,6 @@ suite('Validation Tests', () => {
                 }).then(done, done);
             });
 
-            // TODO: remove this test, because it is just plain wrong: https://yaml.org/type/null.html
-            // See: https://github.com/redhat-developer/yaml-language-server/issues/118
-            it.skip('Null scalar value should be treated as string', done => {
-                const content = 'cwd: Null';
-                const validator = parseSetup(content);
-                validator.then(function (result) {
-                    assert.equal(result.length, 0);
-                }).then(done, done);
-            });
-
             it('Anchor should not not error', done => {
                 const content = 'default: &DEFAULT\n  name: Anchor\nanchor_test:\n  <<: *DEFAULT';
                 const validator = parseSetup(content);