fix: skip local sibling probe in _preferLocalBaseForRemoteId for non-file:// schemas

When a schema is loaded from an https:// URL (e.g. via a VS Code YAML
extension contributor), _preferLocalBaseForRemoteId extracts the basename
from sub-schema $id values and probes for them as local siblings. This
causes spurious HTTP requests that fail with 404 errors.

For example, loading openapi.v3.1.yaml (with $id pointing to
github.com/.../schema.yaml) from an https:// contributor causes a probe
for <contributor-base>/schema.yaml, which does not exist.

The companion function _resolveLocalSiblingFromRemoteUri already guards
against this with `if (parentUri.scheme !== 'file') return undefined`.
Apply the same scheme guard to _preferLocalBaseForRemoteId so the local
sibling optimization only fires for file:// schemas where it makes sense.

Made-with: Cursor

Author: Kosta-Github

src/languageservice/services/yamlSchemaService.ts

@@ -350,6 +350,9 @@ export class YAMLSchemaService extends JSONSchemaService {
     const _preferLocalBaseForRemoteId = async (currentBase: string, id: string): Promise<string> => {
       try {
         const currentBaseUri = URI.parse(currentBase);
+        if (currentBaseUri.scheme !== 'file') {
+          return _resolveAgainstBase(currentBase, id);
+        }
         const idUri = URI.parse(id);
         const localFileName = path.posix.basename(idUri.path);
         const localDir = path.posix.dirname(currentBaseUri.path);

test/yamlSchemaService.test.ts

@@ -406,6 +406,51 @@ describe('YAML Schema Service', () => {
       expect(requestedSecondaryUrisAfterChange).to.have.length(2);
     });
 
+    it('should not probe local sibling paths when schema is loaded from https://', async () => {
+      const content = `# yaml-language-server: $schema=https://example.com/schemas/openapi-extensions.json\nopenapi: '3.1.0'\ninfo:\n  title: Test\n  version: '1.0'`;
+      const yamlDock = parse(content);
+
+      const extensionsSchema = {
+        $id: 'https://example.com/schemas/openapi-extensions.json',
+        $schema: 'http://json-schema.org/draft-04/schema#',
+        allOf: [{ $ref: './openapi.v3.1.json' }],
+      };
+      const openapiSchema = {
+        $id: 'https://github.com/OAI/OpenAPI-Specification/blob/main/schemas/v3.1/schema.json',
+        $schema: 'https://json-schema.org/draft/2020-12/schema',
+        type: 'object',
+        properties: {
+          openapi: { type: 'string', pattern: '^3\\.1\\.\\d+(-.+)?$' },
+          info: {
+            type: 'object',
+            properties: { title: { type: 'string' }, version: { type: 'string' } },
+            required: ['title', 'version'],
+          },
+        },
+        required: ['openapi', 'info'],
+      };
+
+      requestServiceMock = sandbox.fake((uri: string) => {
+        if (uri === 'https://example.com/schemas/openapi-extensions.json') {
+          return Promise.resolve(JSON.stringify(extensionsSchema));
+        }
+        if (uri === 'https://example.com/schemas/openapi.v3.1.json') {
+          return Promise.resolve(JSON.stringify(openapiSchema));
+        }
+        return Promise.reject<string>(`Resource ${uri} not found.`);
+      });
+
+      const service = new SchemaService.YAMLSchemaService(requestServiceMock, workspaceContext);
+      await service.getSchemaForResource('', yamlDock.documents[0]);
+
+      const requestedUris = requestServiceMock.getCalls().map((call) => call.args[0]);
+      expect(requestedUris).to.include('https://example.com/schemas/openapi-extensions.json');
+      expect(requestedUris).to.include('https://example.com/schemas/openapi.v3.1.json');
+      // _preferLocalBaseForRemoteId should NOT probe for the $id basename as a local sibling
+      // when the parent schema was loaded from https:// (not file://)
+      expect(requestedUris).to.not.include('https://example.com/schemas/schema.json');
+    });
+
     it('should handle modeline schema comment in the middle of file', () => {
       const documentContent = `foo:\n  bar\n# yaml-language-server: $schema=https://json-schema.org/draft-07/schema#\naa:bbb\n`;
       const content = `${documentContent}`;