Remove data from unused anchor diagnostics#661
Merged
evidolob merged 1 commit intoredhat-developer:mainfrom Feb 15, 2022
Merged
Remove data from unused anchor diagnostics#661evidolob merged 1 commit intoredhat-developer:mainfrom
evidolob merged 1 commit intoredhat-developer:mainfrom
Conversation
The anchor name was added as custom data. It’s unnecessary, because the name of the anchor can be determined from other values in the place where it’s used. Because Monaco Editor marker data doesn’t support custom data, this blocks support code actions in monaco-yaml.
evidolob
approved these changes
Feb 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The anchor name was added as custom data. It’s unnecessary, because the name of the anchor can be determined from other values in the place where it’s used.
What issues does this PR fix or reference?
Because Monaco Editor marker data doesn’t support custom data, this blocks supports code actions in monaco-yaml.
Is it tested? How?
Manually using monaco-yaml and using tests.