Applying review comments. Updating the type hints pattern - adopting more modern syntax. VectorSets commands are fully covered

Author: petyaslavova

redis/asyncio/cluster.py

@@ -1980,7 +1980,14 @@ class ClusterPipeline(AbstractRedis, AbstractRedisCluster, AsyncRedisClusterComm
         | Existing :class:`~.RedisCluster` client
     """
 
-    __slots__ = ("cluster_client", "_transaction", "_execution_strategy")
+    __slots__ = (
+        "cluster_client",
+        "_transaction",
+        "_execution_strategy",
+        "_is_async_client",
+    )
+
+    _is_async_client: Literal[True] = True
 
     def __init__(
         self, client: RedisCluster, transaction: Optional[bool] = None

redis/asyncio/multidb/client.py

@@ -1,6 +1,6 @@
 import asyncio
 import logging
-from typing import Any, Awaitable, Callable, List, Optional, Union
+from typing import Any, Awaitable, Callable, List, Literal, Optional, Union
 
 from redis.asyncio.client import PubSubHandler
 from redis.asyncio.multidb.command_executor import DefaultCommandExecutor
@@ -441,6 +441,8 @@ class Pipeline(AsyncRedisModuleCommands, AsyncCoreCommands):
     Pipeline implementation for multiple logical Redis databases.
     """
 
+    _is_async_client: Literal[True] = True
+
     def __init__(self, client: MultiDBClient):
         self._command_stack = []
         self._client = client

redis/commands/core.py

@@ -2067,16 +2067,14 @@ def digest(self, name: KeyT) -> Union[str, bytes, None]:
         # Bulk string response is already handled (bytes/str based on decode_responses)
         return self.execute_command("DIGEST", name)
 
-    # --- @overload pattern for get() ---
-    # Sync client returns bytes | None directly
     @overload
-    def get(self: SyncClientProtocol, name: KeyT) -> Optional[bytes]: ...
+    def get(self: SyncClientProtocol, name: KeyT) -> bytes | str | None: ...
 
     # Async client returns Awaitable[bytes | None]
     @overload
-    def get(self: AsyncClientProtocol, name: KeyT) -> Awaitable[Optional[bytes]]: ...
+    def get(self: AsyncClientProtocol, name: KeyT) -> Awaitable[bytes | str | None]: ...
 
-    def get(self, name: KeyT) -> ResponseT:
+    def get(self, name: KeyT) -> (bytes | str | None) | Awaitable[bytes | str | None]:
         """
         Return the value at key ``name``, or None if the key doesn't exist
 
@@ -2566,8 +2564,6 @@ def restore(
 
         return self.execute_command("RESTORE", *params)
 
-    # --- @overload pattern for set() ---
-    # Sync client returns bool | None directly
     @overload
     def set(
         self: SyncClientProtocol,
@@ -2585,7 +2581,7 @@ def set(
         ifne: Optional[Union[bytes, str]] = ...,
         ifdeq: Optional[str] = ...,
         ifdne: Optional[str] = ...,
-    ) -> Optional[bool]: ...
+    ) -> bool | str | bytes | None: ...
 
     # Async client returns Awaitable[bool | None]
     @overload
@@ -2605,7 +2601,7 @@ def set(
         ifne: Optional[Union[bytes, str]] = ...,
         ifdeq: Optional[str] = ...,
         ifdne: Optional[str] = ...,
-    ) -> Awaitable[Optional[bool]]: ...
+    ) -> Awaitable[bool | str | bytes | None]: ...
 
     @experimental_args(["ifeq", "ifne", "ifdeq", "ifdne"])
     def set(
@@ -2624,7 +2620,7 @@ def set(
         ifne: Optional[Union[bytes, str]] = None,
         ifdeq: Optional[str] = None,  # hex digest of current value
         ifdne: Optional[str] = None,  # hex digest of current value
-    ) -> ResponseT:
+    ) -> (bool | str | bytes | None) | Awaitable[bool | str | bytes | None]:
         """
         Set the value at key ``name`` to ``value``
 

redis/commands/search/__init__.py

@@ -1,3 +1,5 @@
+from typing import Literal
+
 from redis.client import Pipeline as RedisPipeline
 
 from ...asyncio.client import Pipeline as AsyncioPipeline
@@ -186,6 +188,10 @@ def pipeline(self, transaction=True, shard_hint=None):
 class Pipeline(SearchCommands, RedisPipeline):
     """Pipeline for the module."""
 
+    _is_async_client: Literal[False] = False
+
 
 class AsyncPipeline(AsyncSearchCommands, AsyncioPipeline, Pipeline):
     """AsyncPipeline for the module."""
+
+    _is_async_client: Literal[True] = True