addressing comments

Author: thiyaguk09

src/bucket.ts

@@ -843,7 +843,7 @@ class Bucket extends ServiceObject<Bucket, BucketMetadata> {
    * that the API failed to retrieve (unreachable) due to partial failure.
    * Consumers must check this flag before accessing other properties.
    */
-  unreachable?: boolean;
+  unreachable = false;
 
   constructor(storage: Storage, name: string, options?: BucketOptions) {
     options = options || {};

src/storage.ts

@@ -1326,7 +1326,6 @@ export class Storage extends Service {
       cb
     );
     options.project = options.project || this.projectId;
-    const returnPartialSuccess = options.returnPartialSuccess || false;
 
     this.request(
       {
@@ -1345,25 +1344,28 @@ export class Storage extends Service {
         const buckets = itemsArray.map((bucket: BucketMetadata) => {
           const bucketInstance = this.bucket(bucket.id!);
           bucketInstance.metadata = bucket;
-          bucketInstance.unreachable = false;
+
           return bucketInstance;
         });
 
-        let unreachableBuckets: Bucket[] = [];
-        if (returnPartialSuccess && unreachableArray.length > 0) {
-          unreachableBuckets = unreachableArray
-            .map((fullPath: string) => {
+        let results: Bucket[] = buckets;
+        if (unreachableArray.length > 0) {
+          results = unreachableArray.reduce(
+            (acc: Bucket[], fullPath: string) => {
               const name = fullPath.split('/').pop();
-              if (!name) return null;
-              const placeholder = this.bucket(name);
-              placeholder.unreachable = true;
-              placeholder.metadata = {};
-              return placeholder;
-            })
-            .filter(Boolean) as Bucket[];
-        }
-        const results = [...buckets, ...unreachableBuckets];
 
+              if (name) {
+                const placeholder = this.bucket(name);
+                placeholder.unreachable = true;
+                placeholder.metadata = {};
+                acc.push(placeholder);
+              }
+
+              return acc;
+            },
+            buckets
+          );
+        }
         const nextQuery = resp.nextPageToken
           ? Object.assign({}, options, {pageToken: resp.nextPageToken})
           : null;

test/index.ts

@@ -1201,45 +1201,17 @@ describe('Storage', () => {
             b => b.name === 'fake-bucket-name'
           );
           assert.ok(reachableBucket);
-          assert.strictEqual(reachableBucket!.unreachable, false);
+          assert.strictEqual(reachableBucket.unreachable, false);
 
           const unreachableBucket = buckets.find(b => b.name === 'fail-bucket');
           assert.ok(unreachableBucket);
-          assert.strictEqual(unreachableBucket!.unreachable, true);
+          assert.strictEqual(unreachableBucket.unreachable, true);
           assert.deepStrictEqual(apiResponse, resp);
           done();
         }
       );
     });
 
-    it('should not return unreachable when returnPartialSuccess is false and unreachable items exist', done => {
-      const unreachableList = ['projects/_/buckets/fail-bucket'];
-      const itemsList = [{id: 'fake-bucket-name'}];
-      const resp = {items: itemsList, unreachable: unreachableList};
-
-      storage.request = (
-        reqOpts: DecorateRequestOptions,
-        callback: Function
-      ) => {
-        assert.strictEqual(reqOpts.qs.returnPartialSuccess, false);
-        callback(null, resp);
-      };
-
-      storage.getBuckets(
-        {returnPartialSuccess: false},
-        (err: Error, buckets: Bucket[], nextQuery: {}, apiResponse: {}) => {
-          assert.ifError(err);
-          assert.strictEqual(buckets.length, itemsList.length);
-          assert.deepStrictEqual(
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            (apiResponse as any).unreachable,
-            unreachableList
-          );
-          done();
-        }
-      );
-    });
-
     it('should handle partial failure with zero reachable buckets', done => {
       const unreachableList = ['projects/_/buckets/fail-bucket'];
       const resp = {items: [], unreachable: unreachableList};