Skip to content

Commit a67fe65

Browse files
committed
fix: modify test cases and remove unreqd fields
1 parent 48e10ef commit a67fe65

3 files changed

Lines changed: 81 additions & 29 deletions

File tree

india_compliance/gst_india/data/test_purchase_reconciliation_tool.json

Lines changed: 81 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,14 @@
2727
"tax_difference": 0.0,
2828
"taxable_value_difference": 0.0,
2929
"project": "",
30-
"cost_center": ""
30+
"cost_center": "",
31+
"gstr_1_filled": 0,
32+
"gstr_3b_filled": 0,
33+
"irn_gen_date": null,
34+
"irn_number": null,
35+
"irn_source": null,
36+
"itc_availability": "Yes",
37+
"reason_itc_unavailability": null
3138
}
3239
},
3340
{
@@ -74,7 +81,14 @@
7481
"tax_difference": 0.0,
7582
"taxable_value_difference": 0.0,
7683
"project": "",
77-
"cost_center": ""
84+
"cost_center": "",
85+
"gstr_1_filled": 0,
86+
"gstr_3b_filled": 0,
87+
"irn_gen_date": null,
88+
"irn_number": null,
89+
"irn_source": null,
90+
"itc_availability": "Yes",
91+
"reason_itc_unavailability": null
7892
}
7993
},
8094
{
@@ -115,7 +129,14 @@
115129
"tax_difference": 0.0,
116130
"taxable_value_difference": 0.0,
117131
"project": "",
118-
"cost_center": ""
132+
"cost_center": "",
133+
"gstr_1_filled": 0,
134+
"gstr_3b_filled": 0,
135+
"irn_gen_date": null,
136+
"irn_number": null,
137+
"irn_source": null,
138+
"itc_availability": "Yes",
139+
"reason_itc_unavailability": null
119140
}
120141
}
121142
],
@@ -148,7 +169,14 @@
148169
"tax_difference": 0.0,
149170
"taxable_value_difference": 0.0,
150171
"project": "",
151-
"cost_center": ""
172+
"cost_center": "",
173+
"gstr_1_filled": 0,
174+
"gstr_3b_filled": 0,
175+
"irn_gen_date": null,
176+
"irn_number": null,
177+
"irn_source": null,
178+
"itc_availability": "Yes",
179+
"reason_itc_unavailability": null
152180
}
153181
}
154182
],
@@ -161,7 +189,7 @@
161189
"bill_no": "BILL-23-00030",
162190
"items": [
163191
{
164-
"taxable_value": 10000.50,
192+
"taxable_value": 10000.5,
165193
"rate": 18,
166194
"sgst": 900.045,
167195
"cgst": 900.045
@@ -188,7 +216,14 @@
188216
"tax_difference": 0.09,
189217
"taxable_value_difference": 0.5,
190218
"project": "",
191-
"cost_center": ""
219+
"cost_center": "",
220+
"gstr_1_filled": 0,
221+
"gstr_3b_filled": 0,
222+
"irn_gen_date": null,
223+
"irn_number": null,
224+
"irn_source": null,
225+
"itc_availability": "Yes",
226+
"reason_itc_unavailability": null
192227
}
193228
}
194229
],
@@ -219,7 +254,14 @@
219254
"tax_difference": 0.0,
220255
"taxable_value_difference": 0.0,
221256
"project": "",
222-
"cost_center": ""
257+
"cost_center": "",
258+
"gstr_1_filled": 0,
259+
"gstr_3b_filled": 0,
260+
"irn_gen_date": null,
261+
"irn_number": null,
262+
"irn_source": null,
263+
"itc_availability": "Yes",
264+
"reason_itc_unavailability": null
223265
}
224266
}
225267
],
@@ -252,7 +294,14 @@
252294
"tax_difference": 0.0,
253295
"taxable_value_difference": 0.0,
254296
"project": "",
255-
"cost_center": ""
297+
"cost_center": "",
298+
"gstr_1_filled": 0,
299+
"gstr_3b_filled": 0,
300+
"irn_gen_date": null,
301+
"irn_number": null,
302+
"irn_source": null,
303+
"itc_availability": "Yes",
304+
"reason_itc_unavailability": null
256305
}
257306
}
258307
],
@@ -285,7 +334,14 @@
285334
"tax_difference": 0.0,
286335
"taxable_value_difference": 0.0,
287336
"project": "",
288-
"cost_center": ""
337+
"cost_center": "",
338+
"gstr_1_filled": 0,
339+
"gstr_3b_filled": 0,
340+
"irn_gen_date": null,
341+
"irn_number": null,
342+
"irn_source": null,
343+
"itc_availability": "Yes",
344+
"reason_itc_unavailability": null
289345
}
290346
}
291347
],
@@ -319,7 +375,14 @@
319375
"tax_difference": 0.0,
320376
"taxable_value_difference": 0.0,
321377
"project": "",
322-
"cost_center": ""
378+
"cost_center": "",
379+
"gstr_1_filled": 0,
380+
"gstr_3b_filled": 0,
381+
"irn_gen_date": null,
382+
"irn_number": null,
383+
"irn_source": null,
384+
"itc_availability": "Yes",
385+
"reason_itc_unavailability": null
323386
}
324387
}
325388
],
@@ -373,7 +436,14 @@
373436
"tax_difference": 0.0,
374437
"taxable_value_difference": 0.0,
375438
"project": "",
376-
"cost_center": ""
439+
"cost_center": "",
440+
"gstr_1_filled": 0,
441+
"gstr_3b_filled": 0,
442+
"irn_gen_date": null,
443+
"irn_number": null,
444+
"irn_source": null,
445+
"itc_availability": "Yes",
446+
"reason_itc_unavailability": null
377447
}
378448
}
379449
]

india_compliance/gst_india/doctype/purchase_reconciliation_tool/__init__.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1032,8 +1032,6 @@ def get_all_inward_supply(self, additional_fields=None, names=None, only_names=F
10321032
"gstr_3b_filled",
10331033
"itc_availability",
10341034
"reason_itc_unavailability",
1035-
"return_period_2b",
1036-
"gen_date_2b",
10371035
"irn_source",
10381036
"irn_number",
10391037
"irn_gen_date",
@@ -1118,8 +1116,6 @@ def process_data(self, reconciliation_data: list, retain_doc: bool = False):
11181116
"gstr_3b_filled": "",
11191117
"itc_availability": "",
11201118
"reason_itc_unavailability": "",
1121-
"return_period_2b": "",
1122-
"gen_date_2b": "",
11231119
"irn_source": "",
11241120
"irn_number": "",
11251121
"irn_gen_date": "",
@@ -1170,8 +1166,6 @@ def update_fields(self, data, purchase, inward_supply):
11701166
"gstr_3b_filled": inward_supply.get("gstr_3b_filled"),
11711167
"itc_availability": inward_supply.get("itc_availability"),
11721168
"reason_itc_unavailability": inward_supply.get("reason_itc_unavailability"),
1173-
"return_period_2b": inward_supply.get("return_period_2b"),
1174-
"gen_date_2b": inward_supply.get("gen_date_2b"),
11751169
"irn_source": inward_supply.get("irn_source"),
11761170
"irn_number": inward_supply.get("irn_number"),
11771171
"irn_gen_date": inward_supply.get("irn_gen_date"),

india_compliance/gst_india/doctype/purchase_reconciliation_tool/purchase_reconciliation_tool.py

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1386,18 +1386,6 @@ def get_invoice_columns(self):
13861386
"data_format": {"horizontal": "left"},
13871387
"header_format": {"width": 25},
13881388
},
1389-
{
1390-
"label": "2B Return Period",
1391-
"fieldname": "return_period_2b",
1392-
"data_format": {"horizontal": "center"},
1393-
"header_format": {"width": 15},
1394-
},
1395-
{
1396-
"label": "2B Generation Date",
1397-
"fieldname": "gen_date_2b",
1398-
"data_format": {"horizontal": "center"},
1399-
"header_format": {"width": 15},
1400-
},
14011389
{
14021390
"label": "GSTR-1 Filed",
14031391
"fieldname": "gstr_1_filled",

0 commit comments

Comments
 (0)