fix: handle localhost domains in cookies

Author: boltlessengineer

lua/rest-nvim/cookie_jar.lua

@@ -54,20 +54,6 @@ function M.load_jar()
     end
 end
 
----parse url to domain and path
----path will be fallback to "/" if not found
----@param url string
----@return string domain
----@return string path
-local function parse_url(url)
-    local domain, path = url:match("^%a+://([^/]+)(/[^?#]*)$")
-    if not path then
-        domain = url:match("^%a+://([^/]+)")
-        path = "/"
-    end
-    return domain, path
-end
-
 ---@private
 ---parse Set-Cookie header to cookie
 ---@param req_url string request URL to be used as fallback domain & path of cookie
@@ -105,7 +91,7 @@ function M.parse_set_cookie(req_url, header)
             cookie.priority = val
         end
     end
-    cookie.domain = cookie.domain or ("." .. req_url:match("^%a+://([^/]+)"))
+    cookie.domain = cookie.domain or ("." .. utils.parse_url(req_url))
     cookie.path = cookie.path or "/"
     if max_age == -1 then
         cookie.expires = -1
@@ -184,7 +170,7 @@ function M.save_jar()
 end
 
 local function match_cookie(url, cookie)
-    local req_domain, req_path = parse_url(url)
+    local req_domain, req_path = utils.parse_url(url)
     if not req_domain then
         return false
     end

lua/rest-nvim/utils.lua

@@ -105,6 +105,17 @@ function utils.parse_http_time(time_str)
     return os.time(time_table) + gmt_offset
 end
 
+---parse url to domain and path
+---path will be fallback to "/" if not found
+---@param url string
+---@return string domain
+---@return string path
+function utils.parse_url(url)
+    local domain = url:match("^%a+://([^/]+)") or url:match("^([^/]+)")
+    local path = url:match("[^:/]+(/[^?#]*)") or "/"
+    return domain, path
+end
+
 --- Default transformers for statistics
 local transform = {
     ---Transform `time` into a readable typed time (e.g. 200ms)

spec/utils_spec.lua

@@ -7,6 +7,27 @@ local function open(path)
     return 0
 end
 
+describe("basic utils", function()
+    it("parse_url", function()
+        local function parse_url(url)
+            local domain, path = utils.parse_url(url)
+            return { domain = domain, path = path }
+        end
+        assert.same({
+            domain = "domain.com",
+            path = "/some/path",
+        }, parse_url("http://domain.com/some/path?query=value"))
+        assert.same({
+            domain = "domain.com",
+            path = "/some/path",
+        }, parse_url("domain.com/some/path?query=value"))
+        assert.same({
+            domain = "localhost:8000",
+            path = "/some/path",
+        }, parse_url("localhost:8000/some/path?query=value"))
+    end)
+end)
+
 describe("tree-sitter utils", function()
     local source = open("spec/examples/script/post_request_script.http")
     it("ts_parse_source", function()