Skip to content
This repository was archived by the owner on Oct 26, 2024. It is now read-only.

Commit 8b09228

Browse files
committed
feat: setting for downloader package name
1 parent 6f5596f commit 8b09228

2 files changed

Lines changed: 8 additions & 9 deletions

File tree

app/src/main/java/app/revanced/integrations/settings/SettingsEnum.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
public enum SettingsEnum {
1515
//Download Settings
1616
// TODO: DOWNLOAD_PATH("revanced_download_path", Environment.getExternalStorageDirectory().getPath() + "/Download", ReturnType.STRING),
17-
DOWNLOAD_BUTTON_SHOWN("revanced_downloads", true, ReturnType.BOOLEAN),
17+
DOWNLOADS_BUTTON_SHOWN("revanced_downloads", true, ReturnType.BOOLEAN),
18+
DOWNLOADS_PACKAGE_NAME("revanced_downloads_package_name", "org.schabi.newpipe" /* NewPipe */, ReturnType.STRING),
1819

1920
//Video Settings
2021
OLD_STYLE_QUALITY_SETTINGS("revanced_use_old_style_quality_settings", true, ReturnType.BOOLEAN),

app/src/main/java/app/revanced/integrations/videoplayer/DownloadButton.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package app.revanced.integrations.videoplayer;
22

3-
import android.app.AlertDialog;
43
import android.content.Context;
54
import android.content.Intent;
65
import android.content.pm.PackageManager;
@@ -48,20 +47,19 @@ public static void initializeDownloadButton(Object obj) {
4847
LogHelper.debug(DownloadButton.class, "Download button clicked");
4948

5049
final var context = view.getContext();
51-
final var powerTubePackageName = "ussr.razar.youtube_dl";
50+
var downloaderPackageName = SettingsEnum.DOWNLOADS_PACKAGE_NAME.getString();
5251

5352
boolean packageEnabled = false;
5453
try {
5554
assert context != null;
56-
packageEnabled = context.getPackageManager().getApplicationInfo(powerTubePackageName, 0).enabled;
55+
packageEnabled = context.getPackageManager().getApplicationInfo(downloaderPackageName, 0).enabled;
5756
} catch (PackageManager.NameNotFoundException error) {
58-
LogHelper.debug(DownloadButton.class, "PowerTube could not be found: " + error);
57+
LogHelper.debug(DownloadButton.class, "Downloader could not be found: " + error);
5958
}
6059

6160
// If the package is not installed, show the toast
6261
if (!packageEnabled) {
63-
Toast.makeText(context, StringRef.str("powertube_not_installed_warning"), Toast.LENGTH_SHORT).show();
64-
Toast.makeText(context, StringRef.str("powertube_not_installed_notice"), Toast.LENGTH_LONG).show();
62+
Toast.makeText(context, downloaderPackageName + " " + StringRef.str("downloader_not_installed_warning"), Toast.LENGTH_LONG).show();
6563
return;
6664
}
6765

@@ -71,7 +69,7 @@ public static void initializeDownloadButton(Object obj) {
7169

7270
Intent intent = new Intent("android.intent.action.SEND");
7371
intent.setType("text/plain");
74-
intent.setPackage(powerTubePackageName);
72+
intent.setPackage(downloaderPackageName);
7573
intent.putExtra("android.intent.extra.TEXT", content);
7674
context.startActivity(intent);
7775

@@ -129,7 +127,7 @@ public static void refreshShouldBeShown() {
129127
}
130128

131129
private static boolean shouldBeShown() {
132-
if (!SettingsEnum.DOWNLOAD_BUTTON_SHOWN.getBoolean()) {
130+
if (!SettingsEnum.DOWNLOADS_BUTTON_SHOWN.getBoolean()) {
133131
return false;
134132
}
135133

0 commit comments

Comments
 (0)