This repository was archived by the owner on Oct 26, 2024. It is now read-only.
refactor(youtube/general-ads-patch): improved exclusion blocking#204
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous exclusion blocking didn't exclude all components of the comments section (such as buttons, textboxes etc.), slowing down the application when scrolling through many comments. This refactor allows to reduce not only the number of values needed for blocking, but (such on the previous code) also avoid the unwanted
history buttonanddownload buttonblockages.