Skip to content

Commit 234295a

Browse files
committed
test(webhdfs): fix async mock misuse and align HTTP error behavior
1 parent c744e01 commit 234295a

1 file changed

Lines changed: 13 additions & 9 deletions

File tree

tests/test_provider_webhdfs.py

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ async def test_get_url_path_with_home(mock_provider):
6363
async def test_do_filestatus_success(mock_provider, fake_request):
6464
mock_response = AsyncMock()
6565
mock_response.status_code = 200
66-
mock_response.raise_for_status = AsyncMock()
66+
mock_response.raise_for_status = MagicMock()
6767

6868
mock_response.json = MagicMock(
6969
return_value={
@@ -142,7 +142,8 @@ async def test_do_get_file_non_range(mock_provider, fake_request):
142142
async def test_do_delete_success(mock_provider, fake_request):
143143
mock_provider._precheck_source = AsyncMock(return_value=(True, True, False))
144144
mock_provider.client.delete.return_value = AsyncMock(
145-
status_code=204, raise_for_status=AsyncMock()
145+
status_code=204,
146+
raise_for_status=MagicMock(),
146147
)
147148

148149
result = await mock_provider._do_delete(fake_request)
@@ -201,17 +202,20 @@ def test_get_url():
201202
async def test_do_filestatus_failure(mock_provider, fake_request):
202203
mock_response = AsyncMock()
203204
mock_response.status_code = 404
204-
mock_response.raise_for_status.side_effect = httpx.HTTPStatusError(
205-
message="Error", request=MagicMock(), response=MagicMock(status_code=404)
205+
mock_response.raise_for_status = MagicMock(
206+
side_effect=httpx.HTTPStatusError(
207+
message="Error",
208+
request=MagicMock(),
209+
response=MagicMock(status_code=404),
210+
)
206211
)
207212
mock_response.json = MagicMock(return_value={"FileStatus": {}})
208213

209214
mock_provider.client.get.return_value = mock_response
210215

211216
url_path = DAVPath("/notfound.txt")
212-
213-
response = await mock_provider._do_filestatus(fake_request, url_path)
214-
assert response == (404, {})
217+
with pytest.raises(httpx.HTTPStatusError):
218+
await mock_provider._do_filestatus(fake_request, url_path)
215219

216220

217221
@pytest.mark.asyncio
@@ -275,7 +279,7 @@ async def test_do_put(mock_provider, fake_request):
275279
mock_response = MagicMock()
276280
mock_response.status_code = 200
277281
mock_response.json = MagicMock(return_value={"FileStatus": {}})
278-
mock_response.raise_for_status = AsyncMock()
282+
mock_response.raise_for_status = MagicMock()
279283

280284
mock_provider.client.get.return_value = mock_response
281285

@@ -399,7 +403,7 @@ async def test_do_move(mock_provider, fake_request):
399403
mock_response = MagicMock()
400404
mock_response.status_code = 200
401405
mock_response.json = MagicMock(return_value={"FileStatus": {}})
402-
mock_response.raise_for_status = AsyncMock()
406+
mock_response.raise_for_status = MagicMock()
403407

404408
mock_provider.client.get.return_value = mock_response
405409

0 commit comments

Comments
 (0)