Skip to content

Commit 664db27

Browse files
authored
Merge pull request #674 from rofrischmann/perf/useFela-props
perf(useFela): optimize passing of theme & props
2 parents ba1da6b + b6293d2 commit 664db27

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

packages/react-fela/src/useFela.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,15 @@ export default function useFela(props: Object = {}): HookInterface {
1515
const renderer = useContext(RendererContext)
1616
const theme = useContext(ThemeContext) || {}
1717

18-
const propsWithTheme = {
19-
...props,
20-
theme,
18+
if (!renderer) {
19+
throw new Error(
20+
'The "useFela" hook can only be used inside a "RendererProvider"'
21+
)
2122
}
2223

24+
const propsWithTheme = { theme }
25+
if (props) Object.assign(propsWithTheme, props)
26+
2327
function css(...rules: Array<Object | Function>) {
2428
return renderer.renderRule(combineRules(...rules), propsWithTheme)
2529
}

0 commit comments

Comments
 (0)