Merge pull request #8213 from FabHof/main

Author: jaredramirez

src/check/Check.zig

@@ -1823,6 +1823,11 @@ fn checkBinopExpr(self: *Self, expr_idx: CIR.Expr.Idx, expr_region: Region, bino
             var does_fx = try self.checkExpr(binop.lhs);
             does_fx = try self.checkExpr(binop.rhs) or does_fx;
 
+            // For equality/comparison, operands must be the same type
+            const lhs_var = @as(Var, @enumFromInt(@intFromEnum(binop.lhs)));
+            const rhs_var = @as(Var, @enumFromInt(@intFromEnum(binop.rhs)));
+            _ = try self.unify(lhs_var, rhs_var);
+
             // Comparison operators always return Bool
             const expr_var = @as(Var, @enumFromInt(@intFromEnum(expr_idx)));
             const fresh_bool = try self.instantiateVarAnon(ModuleEnv.varFrom(can.Can.BUILTIN_BOOL_TYPE), .{ .explicit = expr_region });

src/check/unify.zig

@@ -1576,6 +1576,21 @@ fn Unifier(comptime StoreTypeB: type) type {
                                 .int => return error.TypeMismatch,
                             }
                         },
+                        .num_unbound => |b_num_unbound| {
+                            // Check if the compact type satisfies the requirements
+                            switch (a_num_compact) {
+                                .int => |int_prec| {
+                                    const result = self.checkIntPrecisionRequirements(int_prec, b_num_unbound);
+                                    switch (result) {
+                                        .ok => {},
+                                        .negative_unsigned => return error.NegativeUnsignedInt,
+                                        .too_large => return error.NumberDoesNotFit,
+                                    }
+                                },
+                                .frac => return error.TypeMismatch,
+                            }
+                            self.merge(vars, vars.a.desc.content);
+                        },
                         else => return error.TypeMismatch,
                     }
                 },

test/snapshots/can_list_number_doesnt_fit.md

@@ -8,27 +8,19 @@ type=expr
 [1u8, 2u8, 300]
 ~~~
 # EXPECTED
-INCOMPATIBLE LIST ELEMENTS - can_list_number_doesnt_fit.md:1:7:1:7
+NUMBER DOES NOT FIT IN TYPE - can_list_number_doesnt_fit.md:1:12:1:15
 # PROBLEMS
-**INCOMPATIBLE LIST ELEMENTS**
-The second and third elements in this list have incompatible types:
-**can_list_number_doesnt_fit.md:1:7:**
+**NUMBER DOES NOT FIT IN TYPE**
+The number **300** does not fit in its inferred type:
+**can_list_number_doesnt_fit.md:1:12:1:15:**
 ```roc
 [1u8, 2u8, 300]
 ```
-      ^^^  ^^^
+           ^^^
 
-The second element has this type:
+Its inferred type is:
     _U8_
 
-However, the third element has this type:
-    _Num(_size)_
-
-All elements in a list must have compatible types.
-
-Note: You can wrap each element in a tag to make them compatible.
-To learn about tags, see <https://www.roc-lang.org/tutorial#tags>
-
 # TOKENS
 ~~~zig
 OpenSquare(1:1-1:2),Int(1:2-1:5),Comma(1:5-1:6),Int(1:7-1:10),Comma(1:10-1:11),Int(1:12-1:15),CloseSquare(1:15-1:16),

test/snapshots/if_then_else/if_then_else_nested_chain.md

@@ -131,7 +131,7 @@ NO CHANGE
 ~~~clojure
 (inferred-types
 	(defs
-		(patt @3.1-3.12 (type "_arg -> Str")))
+		(patt @3.1-3.12 (type "Num(_size) -> Str")))
 	(expressions
-		(expr @3.15-13.2 (type "_arg -> Str"))))
+		(expr @3.15-13.2 (type "Num(_size) -> Str"))))
 ~~~

test/snapshots/type_record_basic.md

@@ -13,22 +13,9 @@ getName = |_person| "hello"
 main! = |_| getName({name: "luke", age:21})
 ~~~
 # EXPECTED
-TYPE MISMATCH - type_record_basic.md:6:21:6:43
+NIL
 # PROBLEMS
-**TYPE MISMATCH**
-The first argument being passed to this function has the wrong type:
-**type_record_basic.md:6:21:6:43:**
-```roc
-main! = |_| getName({name: "luke", age:21})
-```
-                    ^^^^^^^^^^^^^^^^^^^^^^
-
-This argument has the type:
-    _{ name: Str, age: Num(_size) }_
-
-But the function needs the first argument to be:
-    _{ age: U64, name: Str }_
-
+NIL
 # TOKENS
 ~~~zig
 KwApp(1:1-1:4),OpenSquare(1:5-1:6),LowerIdent(1:6-1:11),CloseSquare(1:11-1:12),OpenCurly(1:13-1:14),LowerIdent(1:15-1:17),OpColon(1:17-1:18),KwPlatform(1:19-1:27),StringStart(1:28-1:29),StringPart(1:29-1:50),StringEnd(1:50-1:51),CloseCurly(1:52-1:53),