Skip to content

Add plugin for CSS logical properties#170

Merged
robinweser merged 1 commit intorobinweser:masterfrom
cyejia:css-logical-plugin
Feb 6, 2019
Merged

Add plugin for CSS logical properties#170
robinweser merged 1 commit intorobinweser:masterfrom
cyejia:css-logical-plugin

Conversation

@cyejia
Copy link
Copy Markdown
Contributor

@cyejia cyejia commented Feb 5, 2019

Add a plugin to prefix CSS logical properties with the nonstandard
-webkit- and -moz- properties.

Browser version data and supported properties based on
https://caniuse.com/#feat=css-logical-props

@robinweser robinweser self-requested a review February 5, 2019 13:17
Copy link
Copy Markdown
Owner

@robinweser robinweser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that PR, thank you!
But I think we can make it part of the plain property prefixing instead of a custom plugin.
I'll check that later today and get back to you =)

@robinweser
Copy link
Copy Markdown
Owner

robinweser commented Feb 6, 2019

Ok, as I have tried solving that using pure caniuse data I found how this PR is required hehe.
Thanks again for adding that =)

Out as 5.0.4

@robinweser robinweser merged commit acba83c into robinweser:master Feb 6, 2019
@cyejia
Copy link
Copy Markdown
Contributor Author

cyejia commented Feb 6, 2019

Awesome, thank you for such quick response!! :)

@cyejia cyejia deleted the css-logical-plugin branch February 6, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants