Use regex.test(str) instead of str.match(regex)#115
Merged
robinweser merged 1 commit intorobinweser:masterfrom Mar 6, 2017
Merged
Use regex.test(str) instead of str.match(regex)#115robinweser merged 1 commit intorobinweser:masterfrom
robinweser merged 1 commit intorobinweser:masterfrom
Conversation
In all of these places, we really care about a boolean regex match so we can use the much faster regex.test instead of str.match. https://jsperf.com/str-match-vs-regex-test/1 At a glance, I see a few more opportunities for performance improvements (e.g. moving regex declarations up to the module level), but I'm going to leave them for now.
This was referenced Mar 6, 2017
Owner
|
amazing! was not aware of performance differences here :P Feel free to PR any improvements! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In all of these places, we really care about a boolean regex match so
we can use the much faster regex.test instead of str.match.
https://jsperf.com/str-match-vs-regex-test/1
At a glance, I see a few more opportunities for performance
improvements (e.g. moving regex declarations up to the module level),
but I'm going to leave them for now.