Use hasOwnProperty to check for object properties#116
Merged
robinweser merged 1 commit intorobinweser:masterfrom Mar 6, 2017
Merged
Use hasOwnProperty to check for object properties#116robinweser merged 1 commit intorobinweser:masterfrom
robinweser merged 1 commit intorobinweser:masterfrom
Conversation
Contributor
Author
|
In my profiling of Aphrodite's Before, 429ms (21.41% of total
After, 75ms (6.36% of total
It also brings down prefixProperty from ~55ms to ~11ms in my benchmark. |
I've been doing some performance profiling of Aphrodite and noticed that even after updating to inline-style-prefixer 3.0.0, the prefixValue function was still more expensive than I expected. After looking at the CPU profile and the lines highlighted here, it seems that checking for the existence of these object properties using `foo[bar]` is much more expensive than checking using `foo.hasOwnProperty(bar)`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been doing some performance profiling of Aphrodite and noticed that
even after updating to inline-style-prefixer 3.0.0, the prefixValue
function was still more expensive than I expected. After looking at the
CPU profile and the lines highlighted here, it seems that checking for
the existence of these object properties using
foo[bar]is much moreexpensive than checking using
foo.hasOwnProperty(bar).