Merged
Conversation
Signed-off-by: Shane Loretz <sloretz@intrinsic.ai>
Contributor
Author
mjcarroll
approved these changes
Apr 21, 2026
wjwwood
approved these changes
Apr 21, 2026
mini-1235
reviewed
Apr 22, 2026
|
|
||
| <buildtool_depend>ament_cmake</buildtool_depend> | ||
|
|
||
| <build_depend>qt6-base-dev</build_depend> |
There was a problem hiding this comment.
This assumes that qt6 isn't already installed on the system, or that there aren't any other packages in the workspace pulling in qt6, correct? Otherwise, the logic in that sip_helper.cmake file would still resolve to Qt6 and trigger a build error(?)
Out of curiosity, why not make qt6 the default here? Is it because some binaries are missing in noble?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires http://github.com/ros/rosdistro/pull/50844 - which moves
qt6-base-devinto the rosdep keypython3-qt-bindingsso that we can have a consistent Qt version on Ubuntu Noble.Fixes https://build.ros2.org/view/Rbin_uN64/job/Rbin_uN64__qt_gui_cpp__ubuntu_noble_amd64__binary/118/console