php: Support property hooks (#2213)

Author: nsfisis

lib/rouge/lexers/php.rb

@@ -325,7 +325,7 @@ def builtins
         rule %r/=/, Operator, :in_assign
         rule %r/\b(?:public|protected|private|readonly)(?:\(set\)|\b)/i, Keyword
         rule %r/\breadonly\b/i, Keyword
-        rule %r/\??#{id}/, Keyword::Type, :in_assign
+        rule %r/\??#{id}/, Keyword::Type, :in_property
         mixin :escape
         mixin :whitespace
         mixin :variables
@@ -389,7 +389,10 @@ def builtins
         rule %r/\b(?:public|protected|private)(?:\(set\)|\b)/i, Keyword
         rule %r/\b(?:readonly|static)\b/i, Keyword
         rule %r/(?=(abstract|const|function)\b)/i, Keyword, :pop!
-        rule %r/\??#{id}/, Keyword::Type, :pop!
+        rule %r/\??#{id}/ do
+          token Keyword::Type
+          goto :in_property
+        end
         mixin :escape
         mixin :whitespace
         mixin :return
@@ -417,6 +420,51 @@ def builtins
         end
         mixin :php
       end
+
+      state :in_property do
+        rule %r/\$+#{id}/, Name::Variable
+        rule %r/\{/ do
+          token Punctuation
+          goto :in_property_hooks
+        end
+        rule %r/[;,]/, Punctuation, :pop!
+        rule %r/(?==)/ do
+          pop!
+        end
+        rule %r/[|&]/, Operator
+        rule %r/\??#{id}/, Keyword::Type
+        mixin :escape
+        mixin :whitespace
+        mixin :return
+      end
+
+      state :in_property_hooks do
+        rule %r/\}/, Punctuation, :pop!
+        rule %r/\bfinal\b/i, Keyword
+        rule %r/&(?=get\b)/, Operator
+        rule %r/(\bset\b)(\s*)(\()/ do
+          groups Keyword, Text, Punctuation
+          push :in_property_hook_params
+        end
+        rule %r/\b(?:get|set)\b/, Keyword
+        rule %r/\{/, Punctuation, :in_function_body
+        rule %r/[;,\(\)\[\]]/, Punctuation
+        mixin :escape
+        mixin :whitespace
+        mixin :variables
+        mixin :values
+        mixin :names
+        mixin :operators
+        rule %r/[=?]/, Operator
+      end
+
+      state :in_property_hook_params do
+        rule %r/\)/, Punctuation, :pop!
+        rule %r/\??#{id}/, Keyword::Type
+        mixin :escape
+        mixin :whitespace
+        mixin :variables
+      end
     end
   end
 end

spec/visual/samples/php

@@ -409,3 +409,46 @@ class C {
 }
 
 ?>
+
+/* Property Hooks */
+
+<?php
+
+class A {
+    public string $x1 {
+        get {
+            return $this->x1;
+        }
+        set (string $value) {
+            $this->x1 = trim($value);
+        }
+    }
+
+    public string $x2 {
+        get => strtolower($this->x2);
+        set => trim($value);
+    }
+
+    public array $x3 {
+        &get => $this->data;
+    }
+
+    public string $x4 {
+        final get => $this->x6;
+        set => strtolower($value);
+    }
+
+    public function __construct(
+        public string $x5 { get => strtoupper($this->x5); },
+        protected int $x6 {
+            set {
+                if ($value < 0) {
+                    throw new \ValueError('Must be non-negative');
+                }
+                $this->x6 = $value;
+            }
+        },
+    ) {}
+}
+
+?>