Fix various RuboCop todos offences (#2231)

Author: larouxn

.rubocop.yml

@@ -57,8 +57,14 @@ Lint/AmbiguousOperatorPrecedence:
 Naming/BlockForwarding:
   Enabled: false
 
+Naming/PredicateMethod:
+  Enabled: false
+
 Performance/RegexpMatch:
   Enabled: false
 
 Performance/ConstantRegexp:
   Enabled: false
+
+Performance/UnfreezeString:
+  Enabled: false

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-02-13 03:44:28 UTC using RuboCop version 1.84.2.
+# on 2026-02-26 22:49:47 UTC using RuboCop version 1.85.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -20,12 +20,6 @@ Lint/ConstantDefinitionInBlock:
 Lint/DuplicateBranch:
   Enabled: false
 
-# Offense count: 41
-# This cop supports safe autocorrection (--autocorrect).
-Lint/DuplicateSetElement:
-  Exclude:
-    - 'lib/rouge/lexers/glsl.rb'
-
 # Offense count: 3
 # Configuration parameters: AllowComments, AllowEmptyLambdas.
 Lint/EmptyBlock:
@@ -51,21 +45,11 @@ Lint/OutOfRangeRegexpRef:
   Exclude:
     - 'lib/rouge/tex_theme_renderer.rb'
 
-# Offense count: 1
-Lint/SharedMutableDefault:
-  Exclude:
-    - 'lib/rouge/lexers/j.rb'
-
 # Offense count: 1
 Lint/ToEnumArguments:
   Exclude:
     - 'lib/rouge/lexer.rb'
 
-# Offense count: 1
-Lint/UselessConstantScoping:
-  Exclude:
-    - 'lib/rouge/formatters/terminal256.rb'
-
 # Offense count: 43
 Naming/ConstantName:
   Exclude:
@@ -110,17 +94,6 @@ Naming/MethodName:
 Naming/MethodParameterName:
   Enabled: false
 
-# Offense count: 4
-# Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
-# AllowedMethods: call
-# WaywardPredicates: infinite?, nonzero?
-Naming/PredicateMethod:
-  Exclude:
-    - 'lib/rouge/guessers/util.rb'
-    - 'lib/rouge/lexers/javascript.rb'
-    - 'lib/rouge/regex_lexer.rb'
-    - 'spec/visual/app.rb'
-
 # Offense count: 40
 # Configuration parameters: EnforcedStyle, AllowedIdentifiers, AllowedPatterns, ForbiddenIdentifiers, ForbiddenPatterns.
 # SupportedStyles: snake_case, camelCase
@@ -144,96 +117,10 @@ Naming/VariableNumber:
 
 # Offense count: 2
 # This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/MapCompact:
-  Exclude:
-    - 'lib/rouge/guessers/glob_mapping.rb'
-    - 'lib/rouge/guessers/modeline.rb'
-
-# Offense count: 1
-Performance/MapMethodChain:
-  Exclude:
-    - 'lib/rouge/regex_lexer.rb'
-
-# Offense count: 7
-Performance/MethodObjectAsBlock:
-  Exclude:
-    - 'lib/rouge/cli.rb'
-    - 'lib/rouge/formatters/tex.rb'
-    - 'lib/rouge/lexers/console.rb'
-    - 'spec/visual/app.rb'
-
-# Offense count: 12
-# This cop supports unsafe autocorrection (--autocorrect-all).
 Performance/StringInclude:
   Exclude:
-    - 'lib/rouge/cli.rb'
     - 'lib/rouge/lexers/hack.rb'
-    - 'lib/rouge/lexers/igorpro.rb'
-    - 'lib/rouge/lexers/lua.rb'
-    - 'lib/rouge/lexers/moonscript.rb'
-    - 'spec/formatters/html_pygments_spec.rb'
-    - 'spec/lexers/escape_spec.rb'
-    - 'spec/theme_spec.rb'
 
-# Offense count: 5
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/UnfreezeString:
-  Exclude:
-    - 'lib/rouge/cli.rb'
-    - 'lib/rouge/formatter.rb'
-    - 'lib/rouge/formatters/terminal_truecolor.rb'
-    - 'lib/rouge/tex_theme_renderer.rb'
-    - 'spec/lexers_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Rake/Desc:
-  Exclude:
-    - 'Rakefile'
-
-# Offense count: 119
+# Offense count: 118
 Rouge/NoBuildingAlternationPatternInRegexp:
-  Exclude:
-    - 'lib/rouge/lexers/apple_script.rb'
-    - 'lib/rouge/lexers/armasm.rb'
-    - 'lib/rouge/lexers/bbcbasic.rb'
-    - 'lib/rouge/lexers/bicep.rb'
-    - 'lib/rouge/lexers/cfscript.rb'
-    - 'lib/rouge/lexers/cmhg.rb'
-    - 'lib/rouge/lexers/console.rb'
-    - 'lib/rouge/lexers/crystal.rb'
-    - 'lib/rouge/lexers/csharp.rb'
-    - 'lib/rouge/lexers/d.rb'
-    - 'lib/rouge/lexers/dart.rb'
-    - 'lib/rouge/lexers/eiffel.rb'
-    - 'lib/rouge/lexers/elm.rb'
-    - 'lib/rouge/lexers/erlang.rb'
-    - 'lib/rouge/lexers/haskell.rb'
-    - 'lib/rouge/lexers/http.rb'
-    - 'lib/rouge/lexers/idris.rb'
-    - 'lib/rouge/lexers/idris.rb'
-    - 'lib/rouge/lexers/isabelle.rb'
-    - 'lib/rouge/lexers/java.rb'
-    - 'lib/rouge/lexers/jsp.rb'
-    - 'lib/rouge/lexers/kotlin.rb'
-    - 'lib/rouge/lexers/lean.rb'
-    - 'lib/rouge/lexers/magik.rb'
-    - 'lib/rouge/lexers/make.rb'
-    - 'lib/rouge/lexers/mason.rb'
-    - 'lib/rouge/lexers/moonscript.rb'
-    - 'lib/rouge/lexers/mosel.rb'
-    - 'lib/rouge/lexers/nix.rb'
-    - 'lib/rouge/lexers/p4.rb'
-    - 'lib/rouge/lexers/pascal.rb'
-    - 'lib/rouge/lexers/perl.rb'
-    - 'lib/rouge/lexers/postscript.rb'
-    - 'lib/rouge/lexers/python.rb'
-    - 'lib/rouge/lexers/r.rb'
-    - 'lib/rouge/lexers/ruby.rb'
-    - 'lib/rouge/lexers/rust.rb'
-    - 'lib/rouge/lexers/scala.rb'
-    - 'lib/rouge/lexers/sml.rb'
-    - 'lib/rouge/lexers/stata.rb'
-    - 'lib/rouge/lexers/vala.rb'
-    - 'lib/rouge/lexers/wollok.rb'
-    - 'lib/rouge/lexers/xojo.rb'
+  Enabled: false

Rakefile

@@ -16,6 +16,7 @@ task :test => [:check]
 task :build => [:clean, :check, "generate:docs"]
 
 # Add utility tasks
+desc 'Add a newline'
 task :newline do
   puts
 end
@@ -29,6 +30,7 @@ end
 def alias_task(aliases)
   aliases.each do |alias_name,task_name|
     t = Rake::Task[task_name]
+    desc "Add legacy alias #{alias_name} for modern #{task_name} task"
     task alias_name, *t.arg_names do |_, args|
       args = t.arg_names.map { |a| args[a] }
       t.invoke(args)

lib/rouge/cli.rb

@@ -159,7 +159,7 @@ def initialize(opts={})
       end
 
       def run
-        @mode.doc.each(&method(:puts))
+        @mode.doc.each { |line| puts line }
       end
     end
 
@@ -212,7 +212,7 @@ def self.doc
       # and we provide explicit opt-in and opt-out with $COLORTERM
       def self.supports_truecolor?
         return true if %w(24bit truecolor).include?(ENV['COLORTERM'])
-        return false if ENV['COLORTERM'] && ENV['COLORTERM'] =~ /256/
+        return false if ENV['COLORTERM'] && ENV['COLORTERM'].include?('256')
 
         if RbConfig::CONFIG['host_os'] =~ /mswin|mingw/
           ENV['ConEmuANSI'] == 'ON' && !ENV['ANSICON']
@@ -344,7 +344,7 @@ def initialize(opts={})
 
       def run
         Formatter.enable_escape! if @escape
-        formatter.format(lexer.lex(input), &method(:print))
+        formatter.format(lexer.lex(input)) { |piece| print piece }
       end
 
     private_class_method def self.parse_cgi(str)
@@ -439,7 +439,7 @@ def initialize(opts)
       end
 
       def run
-        @theme.render(&method(:puts))
+        @theme.render { |line| puts line }
       end
     end
 

lib/rouge/formatters/terminal256.rb

@@ -7,6 +7,9 @@ module Formatters
     class Terminal256 < Formatter
       tag 'terminal256'
 
+      # max distance between two colors, #000000 to #ffffff
+      MAX_DISTANCE = 257 * 257 * 3
+
       # @private
       attr_reader :theme
 
@@ -138,9 +141,6 @@ def self.get_rgb(color)
           hexes.map { |h| h.to_i(16) }
         end
 
-        # max distance between two colors, #000000 to #ffffff
-        MAX_DISTANCE = 257 * 257 * 3
-
         def self.closest_color(r, g, b)
           @@colors_cache ||= {}
           key = (r << 16) + (g << 8) + b

lib/rouge/formatters/tex.rb

@@ -28,7 +28,7 @@ class Tex < Formatter
         "\t" => '{\tab}',
       }
 
-      ESCAPE_REGEX = /[#{ESCAPE.keys.map(&Regexp.method(:escape)).join}]/om
+      ESCAPE_REGEX = /[#{ESCAPE.keys.map { |k| Regexp.escape(k) }.join}]/om
 
       def initialize(opts={})
         @prefix = opts.fetch(:prefix) { 'RG' }

lib/rouge/guessers/disambiguation.rb

@@ -90,7 +90,7 @@ def match?(filename)
       disambiguate '*.m' do
         next ObjectiveC if matches?(/@(end|implementation|protocol|property)\b/)
         next ObjectiveC if contains?('@"')
-        
+
         # Objective-C dereferenced pointers and Mathematica comments are similar.
         # Disambiguate for Mathematica by looking for any amount of whitespace (or no whitespace)
         # followed by "(*" (e.g. `(* comment *)`).
@@ -107,7 +107,7 @@ def match?(filename)
         next Matlab if matches?(/^\s*?%/)
         # Matlab cell array creation: data = {
         next Matlab if matches?(/^\s*[a-zA-Z]\w*\s*=\s*\{/)
-        
+
         next Mason if matches? %r!(</?%|<&)!
       end
 

lib/rouge/guessers/glob_mapping.rb

@@ -32,12 +32,12 @@ def filter(lexers)
         basename = File.basename(filename)
 
         collect_best(lexers) do |lexer|
-          (@glob_map[lexer.name] || []).map do |pattern|
+          (@glob_map[lexer.name] || []).filter_map do |pattern|
             if test_glob(pattern, basename)
               # specificity is better the fewer wildcards there are
               -pattern.scan(/[*?\[]/).size
             end
-          end.compact.min
+          end.min
         end
       end
     end

lib/rouge/guessers/modeline.rb

@@ -35,7 +35,7 @@ def filter(lexers)
 
         search_space = (lines.first(@lines) + lines.last(@lines)).join("\n")
 
-        matches = MODELINES.map { |re| re.match(search_space) }.compact
+        matches = MODELINES.filter_map { |re| re.match(search_space) }
         return lexers unless matches.any?
 
         match_set = Set.new(matches.map { |m| m[1] })

lib/rouge/lexers/console.rb

@@ -85,7 +85,7 @@ def end_chars
 
       def error_regex
         @error_regex ||= if @error.any?
-          /^(?:#{@error.map(&Regexp.method(:escape)).join('|')})/
+          /^(?:#{@error.map { |e| Regexp.escape(e) }.join('|')})/
         end
       end
 
@@ -174,7 +174,7 @@ def prompt_prefix_regex
 
       def prompt_regex
         @prompt_regex ||= begin
-          /^#{prompt_prefix_regex}(?:#{end_chars.map(&Regexp.method(:escape)).join('|')})/
+          /^#{prompt_prefix_regex}(?:#{end_chars.map { |c| Regexp.escape(c) }.join('|')})/
         end
       end