Safe auto-correct and manually fix RuboCop infractions and regen todo (#2206)

Author: larouxn

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-02-13 03:42:44 UTC using RuboCop version 1.84.2.
+# on 2026-02-13 03:44:28 UTC using RuboCop version 1.84.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -20,10 +20,11 @@ Lint/ConstantDefinitionInBlock:
 Lint/DuplicateBranch:
   Enabled: false
 
-# Offense count: 149
+# Offense count: 41
 # This cop supports safe autocorrection (--autocorrect).
 Lint/DuplicateSetElement:
-  Enabled: false
+  Exclude:
+    - 'lib/rouge/lexers/glsl.rb'
 
 # Offense count: 3
 # Configuration parameters: AllowComments, AllowEmptyLambdas.
@@ -55,14 +56,6 @@ Lint/SharedMutableDefault:
   Exclude:
     - 'lib/rouge/lexers/j.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, consistent
-Lint/SymbolConversion:
-  Exclude:
-    - 'lib/rouge/lexers/postscript.rb'
-
 # Offense count: 1
 Lint/ToEnumArguments:
   Exclude:
@@ -79,23 +72,6 @@ Naming/ConstantName:
     - 'lib/rouge/lexers/eiffel.rb'
     - 'lib/rouge/themes/gruvbox.rb'
 
-# Offense count: 21
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: lowercase, uppercase
-Naming/HeredocDelimiterCase:
-  Exclude:
-    - 'rouge.gemspec'
-    - 'spec/lexers/diff_spec.rb'
-    - 'spec/lexers/haml_spec.rb'
-    - 'spec/lexers/html_spec.rb'
-    - 'spec/lexers/mason_spec.rb'
-    - 'spec/lexers/matlab_spec.rb'
-    - 'spec/lexers/shell_spec.rb'
-    - 'spec/plugins/redcarpet_spec.rb'
-    - 'spec/theme_spec.rb'
-    - 'spec/visual_spec.rb'
-
 # Offense count: 8
 # Configuration parameters: ForbiddenDelimiters.
 # ForbiddenDelimiters: (?i-mx:(^|\s)(EO[A-Z]{1}|END)(\s|$))
@@ -186,22 +162,6 @@ Performance/MethodObjectAsBlock:
     - 'lib/rouge/lexers/console.rb'
     - 'spec/visual/app.rb'
 
-# Offense count: 10
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RedundantBlockCall:
-  Exclude:
-    - 'lib/rouge/guesser.rb'
-    - 'lib/rouge/lexer.rb'
-    - 'lib/rouge/regex_lexer.rb'
-    - 'lib/rouge/token.rb'
-    - 'lib/rouge/util.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RedundantSplitRegexpArgument:
-  Exclude:
-    - 'lib/rouge/guessers/modeline.rb'
-
 # Offense count: 12
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Performance/StringInclude:

lib/rouge/guesser.rb

@@ -35,7 +35,7 @@ def collect_best(lexers, opts={}, &scorer)
       best_score = opts[:threshold]
 
       lexers.each do |lexer|
-        score = scorer.call(lexer)
+        score = yield(lexer)
 
         next if score.nil?
 

lib/rouge/guessers/modeline.rb

@@ -31,7 +31,7 @@ def filter(lexers)
 
         source_text = get_source(@source)
 
-        lines = source_text.split(/\n/)
+        lines = source_text.split("\n")
 
         search_space = (lines.first(@lines) + lines.last(@lines)).join("\n")
 

lib/rouge/lexer.rb

@@ -183,7 +183,7 @@ def guess(info={}, &fallback)
         return lexers[0] if lexers.size == 1
 
         if fallback
-          fallback.call(lexers)
+          yield(lexers)
         else
           raise Guesser::Ambiguous.new(lexers)
         end
@@ -420,7 +420,7 @@ def bool_option(name, &default)
       if @options.key?(name_str)
         as_bool(@options[name_str])
       else
-        default ? default.call : false
+        default ? yield : false
       end
     end
 
@@ -446,13 +446,13 @@ def hash_option(name, defaults, &val_cast)
 
       base = @options.delete(name.to_s)
       base = {} unless base.is_a?(Hash)
-      base.each { |k, v| out[k.to_s] = val_cast ? val_cast.call(v) : v }
+      base.each { |k, v| out[k.to_s] = val_cast ? yield(v) : v }
 
       @options.keys.each do |key|
         next unless key =~ /(\w+)\[(\w+)\]/ and $1 == name
         value = @options.delete(key)
 
-        out[$2] = val_cast ? val_cast.call(value) : value
+        out[$2] = val_cast ? yield(value) : value
       end
 
       out
@@ -513,12 +513,12 @@ def continue_lex(string, &b)
           next
         end
 
-        b.call(last_token, last_val) if last_token
+        yield(last_token, last_val) if last_token
         last_token = tok
         last_val = val
       end
 
-      b.call(last_token, last_val) if last_token
+      yield(last_token, last_val) if last_token
     end
 
     # delegated to {Lexer.tag}

lib/rouge/lexers/apex.rb

@@ -30,8 +30,8 @@ def self.declarations
       def self.soql
         @soql ||= Set.new %w(
           SELECT FROM WHERE UPDATE LIKE TYPEOF END USING SCOPE WITH DATA
-          CATEGORY GROUP BY ROLLUP CUBE HAVING ORDER BY ASC DESC NULLS FIRST
-          LAST LIMIT OFFSET FOR VIEW REFERENCE UPDATE TRACKING VIEWSTAT OR AND
+          CATEGORY GROUP BY ROLLUP CUBE HAVING ORDER ASC DESC NULLS FIRST
+          LAST LIMIT OFFSET FOR VIEW REFERENCE TRACKING VIEWSTAT OR AND
         )
       end
 

lib/rouge/lexers/brightscript.rb

@@ -64,19 +64,18 @@ def self.builtins
         @builtins ||= Set.new %w(
           roAppendFile roAppInfo roAppManager roArray roAssociativeArray
           roAudioGuide roAudioMetadata roAudioPlayer roAudioPlayerEvent
-          roAudioResourceroBitmap roBoolean roBoolean roBrightPackage roBrSub
+          roAudioResourceroBitmap roBoolean roBrightPackage roBrSub
           roButton roByteArray roCaptionRenderer roCaptionRendererEvent
           roCecInterface roCECStatusEvent roChannelStore roChannelStoreEvent
           roClockWidget roCodeRegistrationScreen
-          roCodeRegistrationScreenEventroCompositor roControlDown roControlPort
-          roControlPort roControlUp roCreateFile roDatagramReceiver
+          roCodeRegistrationScreenEventroCompositor roControlDown roControlPort roControlUp roCreateFile roDatagramReceiver
           roDatagramSender roDataGramSocket roDateTime roDeviceInfo
           roDeviceInfoEvent roDoubleroEVPCipher roEVPDigest roFileSystem
           roFileSystemEvent roFloat roFont roFontMetrics roFontRegistry
           roFunction roGlobal roGpio roGridScreen roGridScreenEvent
           roHdmiHotPlugEventroHdmiStatus roHdmiStatusEvent roHMAC roHttpAgent
           roImageCanvas roImageCanvasEvent roImageMetadata roImagePlayer
-          roImageWidgetroInput roInputEvent roInt roInt roInvalid roInvalid
+          roImageWidgetroInput roInputEvent roInt roInvalid
           roIRRemote roKeyboard roKeyboardPress roKeyboardScreen
           roKeyboardScreenEventroList roListScreen roListScreenEvent
           roLocalization roLongInteger roMessageDialog roMessageDialogEvent

lib/rouge/lexers/coq.rb

@@ -38,7 +38,7 @@ def self.ltac
           edestruct constructor econstructor eexists exists
           f_equal refine instantiate revert simpl
           specialize generalize dependent red induction
-          beta iota zeta delta exfalso autorewrite setoid_rewrite
+          beta iota zeta delta exfalso autorewrite
           compute vm_compute native_compute
         )
       end

lib/rouge/lexers/css.rb

@@ -126,7 +126,7 @@ def self.builtins
           above absolute accumulate add additive all alpha alphabetic
           alternate alternate-reverse always armenian aural auto auto-fill
           auto-fit avoid backwards balance baseline behind below bidi-override
-          blink block bold bolder border-box both bottom bottom break-spaces
+          blink block bold bolder border-box both bottom break-spaces
           capitalize center center-left center-right circle cjk-ideographic
           close-quote closest-corner closest-side collapse
           color color-burn color-dodge column column-reverse

lib/rouge/lexers/ecl.rb

@@ -42,9 +42,9 @@ def self.functions
           row rowdiff sample set sin sinh sizeof soapcall sort sorted sqrt
           stepped stored sum table tan tanh thisnode topn tounicode toxml
           transfer transform trim truncate typeof ungroup unicodeorder variance
-          which workunit xmldecode xmlencode xmltext xmlunicode apply assert
-          build buildindex evaluate fail keydiff keypatch loadxml nothor notify
-          output parallel sequential soapcall wait
+          which workunit xmldecode xmlencode xmltext xmlunicode assert
+          build buildindex fail keydiff keypatch loadxml nothor notify
+          output parallel sequential wait
         )
       end
 

lib/rouge/lexers/factor.rb

@@ -25,7 +25,7 @@ def self.builtins
             do unless* if* loop bi-curry* drop when* assert= retainstack
             assert? -rot execute 2bi@ 2tri@ boa with either? 3drop bi
             curry?  datastack until 3dip over 3curry tri-curry* tri-curry@
-            swap and 2nip throw bi-curry (clone) hashcode* compose 2dip if
+            swap and 2nip throw bi-curry (clone) hashcode* compose 2dip
             3tri unless compose? tuple keep 2curry equal? assert tri 2drop
             most <wrapper> boolean? identity-hashcode identity-tuple?
             null new dip bi-curry@ rot xor identity-tuple boolean