-
Notifications
You must be signed in to change notification settings - Fork 187
Added a devour healing routine for necromancers to safe-room. #2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rpherbig
merged 12 commits into
elanthia-online:master
from
jbrock24:add-necro-devour-safe-room-healing
Jan 6, 2018
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
0b827b0
Added a devour healing routine for necromancers to safe-room. This sh…
jbrock24 bb8c3eb
Added better skipping logic.
jbrock24 e9dda75
Added a new setting for this, also removed the extra checking which I…
jbrock24 4aff013
Added a break for the failure message.
jbrock24 255168d
Changed the setting name, and updated some parameter checking.
jbrock24 0d4172f
Added a validate for the required settings.
jbrock24 81fafae
Changed the name again, added it as a setting...
jbrock24 3f2e607
Fixed check
jbrock24 ede3a9a
Updating the logic to not skip give_and_take, and to store material i…
jbrock24 5f7dba9
Didn't like the name, changed it.
jbrock24 24f36a9
Adding another validate for false storing but using devour to heal. A…
jbrock24 8c82808
Forgot to remove the DRCA. call
jbrock24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding a validator for the case in which the user has
thanatology['store'] = falsebutnecro_safe_room_use_material: true?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, good call.