fix: resolve all clippy warnings (collapsible_if, from_str rename)

Author: pszymkowiak

src/backend/qwen.rs

@@ -108,8 +108,8 @@ fn play_wav(path: &Path) -> Result<Child> {
 
 /// Remove orphaned `audio_*.wav` files from the current working directory.
 fn cleanup_cwd_wav() {
-    if let Ok(dir) = std::env::current_dir() {
-        if let Ok(entries) = std::fs::read_dir(&dir) {
+    if let Ok(dir) = std::env::current_dir()
+        && let Ok(entries) = std::fs::read_dir(&dir) {
             for entry in entries.flatten() {
                 let name = entry.file_name();
                 let name_str = name.to_string_lossy();
@@ -118,7 +118,6 @@ fn cleanup_cwd_wav() {
                 }
             }
         }
-    }
 }
 
 impl TtsBackend for QwenBackend {

src/chat.rs

@@ -152,7 +152,7 @@ fn speak_text(text: &str, config: &ChatConfig) -> Result<()> {
 fn is_exit(text: &str) -> bool {
     let lower = text.to_lowercase();
     let trimmed = lower.trim().trim_end_matches(['.', '!', '?']);
-    EXIT_WORDS.iter().any(|w| trimmed == *w)
+    EXIT_WORDS.contains(&trimmed)
 }
 
 pub fn run_chat_loop(config: ChatConfig) -> Result<()> {

src/config.rs

@@ -20,7 +20,7 @@ impl Gender {
         }
     }
 
-    pub fn from_str(s: &str) -> anyhow::Result<Self> {
+    pub fn parse(s: &str) -> anyhow::Result<Self> {
         match s {
             "feminine" => Ok(Gender::Feminine),
             "masculine" => Ok(Gender::Masculine),
@@ -51,7 +51,7 @@ impl IntonationStyle {
         }
     }
 
-    pub fn from_str(s: &str) -> anyhow::Result<Self> {
+    pub fn parse(s: &str) -> anyhow::Result<Self> {
         match s {
             "calm" => Ok(IntonationStyle::Calm),
             "energetic" => Ok(IntonationStyle::Energetic),

src/db.rs

@@ -115,10 +115,10 @@ pub fn set_preference(conn: &Connection, key: &str, value: &str) -> Result<()> {
     // Validate specific keys
     match key {
         "gender" => {
-            config::Gender::from_str(value)?;
+            config::Gender::parse(value)?;
         }
         "style" => {
-            config::IntonationStyle::from_str(value)?;
+            config::IntonationStyle::parse(value)?;
         }
         "rate" => {
             value

src/init.rs

@@ -48,25 +48,21 @@ pub fn claude_md_has_vox(content: &str) -> bool {
 
 /// Checks whether a parsed settings.json already has a vox hook.
 pub fn has_vox_hook(settings: &Value) -> bool {
-    if let Some(hooks) = settings.get("hooks") {
-        if let Some(stop) = hooks.get("Stop") {
-            if let Some(arr) = stop.as_array() {
+    if let Some(hooks) = settings.get("hooks")
+        && let Some(stop) = hooks.get("Stop")
+            && let Some(arr) = stop.as_array() {
                 for entry in arr {
-                    if let Some(inner_hooks) = entry.get("hooks") {
-                        if let Some(inner_arr) = inner_hooks.as_array() {
+                    if let Some(inner_hooks) = entry.get("hooks")
+                        && let Some(inner_arr) = inner_hooks.as_array() {
                             for h in inner_arr {
-                                if let Some(cmd) = h.get("command").and_then(|c| c.as_str()) {
-                                    if cmd.starts_with("vox ") {
+                                if let Some(cmd) = h.get("command").and_then(|c| c.as_str())
+                                    && cmd.starts_with("vox ") {
                                         return true;
                                     }
-                                }
                             }
                         }
-                    }
                 }
             }
-        }
-    }
     false
 }
 
@@ -100,8 +96,8 @@ pub fn build_settings(existing: Option<&str>) -> Result<String> {
             }
 
             // Merge hooks
-            if let Some(new_hooks) = vox_hook.get("hooks") {
-                if let Some(new_stop) = new_hooks.get("Stop") {
+            if let Some(new_hooks) = vox_hook.get("hooks")
+                && let Some(new_stop) = new_hooks.get("Stop") {
                     let base_obj = base
                         .as_object_mut()
                         .context("settings.json is not an object")?;
@@ -115,13 +111,11 @@ pub fn build_settings(existing: Option<&str>) -> Result<String> {
                     let stop_arr = hooks_map
                         .entry("Stop")
                         .or_insert_with(|| Value::Array(vec![]));
-                    if let Some(arr) = stop_arr.as_array_mut() {
-                        if let Some(new_entries) = new_stop.as_array() {
+                    if let Some(arr) = stop_arr.as_array_mut()
+                        && let Some(new_entries) = new_stop.as_array() {
                             arr.extend(new_entries.clone());
                         }
-                    }
                 }
-            }
 
             base
         }

src/main.rs

@@ -156,14 +156,13 @@ fn handle_speak(cli: Cli) -> Result<()> {
     let mut ref_text = None;
     let mut effective_backend = backend_name.clone();
 
-    if let Some(ref voice_name) = voice {
-        if let Some(vc) = clone::resolve_voice(&conn, voice_name)? {
+    if let Some(ref voice_name) = voice
+        && let Some(vc) = clone::resolve_voice(&conn, voice_name)? {
             ref_audio = Some(vc.ref_audio);
             ref_text = vc.ref_text;
             effective_backend = "qwen".to_string();
             voice = None; // don't pass clone name as --voice
         }
-    }
 
     let backend = backend::get_backend(&effective_backend)?;