Merge pull request #1627 from nicholasdower/try

Fix false positives for try and try! in Rails/StrongParametersExpect

Author: koic

changelog/fix_false_positives_for_try_in_rails_strong_parameters_expect.md

@@ -0,0 +1 @@
+* [#1627](https://github.com/rubocop/rubocop-rails/pull/1627): Fix false positives in `Rails/StrongParametersExpect` for usages like `params[:key].try(:method)` and `params[:key].try!(:method)`. ([@nicholasdower][])

lib/rubocop/cop/rails/strong_parameters_expect.rb

@@ -55,7 +55,7 @@ class StrongParametersExpect < Base
         MSG = 'Use `%<prefer>s` instead.'
         RESTRICT_ON_SEND = %i[[] require permit].freeze
         PRESENCE_CHECK_METHODS = %i[nil? blank? present? presence].freeze
-        NIL_SAFE_METHODS = %i[instance_of? is_a? kind_of? to_a to_f to_h to_i to_s].freeze
+        NIL_SAFE_METHODS = %i[instance_of? is_a? kind_of? to_a to_f to_h to_i to_s try try!].freeze
         KEY_CHECK_METHODS = %i[key? has_key? include? member?].freeze
         RAISING_FINDER_METHODS = %i[find find_by! find_sole_by].freeze
 

spec/rubocop/cop/rails/strong_parameters_expect_spec.rb

@@ -73,6 +73,18 @@
       RUBY
     end
 
+    it 'does not register an offense when using `params[:key].try(:method)`' do
+      expect_no_offenses(<<~RUBY)
+        params[:key].try(:method)
+      RUBY
+    end
+
+    it 'does not register an offense when using `params[:key].try!(:method)`' do
+      expect_no_offenses(<<~RUBY)
+        params[:key].try!(:method)
+      RUBY
+    end
+
     it 'does not register an offense when using `params[:key].key?(:inner)`' do
       expect_no_offenses(<<~RUBY)
         params[:key].key?(:inner)