html_escape: refactor redundant if (#88)

noteflakes · web-flow · commit c231ced3f4c1 · 2025-10-13T22:48:31.000+08:00
diff --git a/ext/erb/escape/escape.c b/ext/erb/escape/escape.c
@@ -63,16 +63,13 @@ optimized_escape_html(VALUE str)
             dest += len;
         }
     }
+    VALUE escaped = str;
     if (buf) {
         size_t segment_len = cstr - segment_start;
         if (segment_len) {
             memcpy(dest, segment_start, segment_len);
             dest += segment_len;
         }
-    }
-
-    VALUE escaped = str;
-    if (buf) {
         escaped = rb_str_new(buf, dest - buf);
         preserve_original_state(str, escaped);
         ALLOCV_END(vbuf);

Original file line number	Diff line number	Diff line change
`@@ -63,16 +63,13 @@ optimized_escape_html(VALUE str)`
`63`	`63`	`dest += len;`
`64`	`64`	`}`
`65`	`65`	`}`
	`66`	`+ VALUE escaped = str;`
`66`	`67`	`if (buf) {`
`67`	`68`	`size_t segment_len = cstr - segment_start;`
`68`	`69`	`if (segment_len) {`
`69`	`70`	`memcpy(dest, segment_start, segment_len);`
`70`	`71`	`dest += segment_len;`
`71`	`72`	`}`
`72`		`- }`
`73`		`-`
`74`		`- VALUE escaped = str;`
`75`		`- if (buf) {`
`76`	`73`	`escaped = rb_str_new(buf, dest - buf);`
`77`	`74`	`preserve_original_state(str, escaped);`
`78`	`75`	`ALLOCV_END(vbuf);`