This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Implements Read on HexIterator#135
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Dec 23, 2021
Merged
Conversation
Member
|
concept ACK. It's been a month, maybe worth just kicking the PR and see if CI is fixed? |
Contributor
Author
|
I re-kicked (by re-pushing on a different branch, I havent't permission to re-kick here) https://github.com/RCasatta/bitcoin_hashes/actions/runs/1602919828 but it didn't work. Now I noticed we have the same issue also in master https://github.com/rust-bitcoin/bitcoin_hashes/actions/runs/1602516688 |
Contributor
|
weird, not sure what would have broken them. I spent some time last month looking at this, but couldn't figure it out either. |
Member
|
I think it was fixed in #140 |
37a099a to
60f51d9
Compare
Contributor
Author
|
Rebased, thanks for the fix @JeremyRubin |
apoelstra
approved these changes
Dec 23, 2021
Collaborator
|
This looks super cool! :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow deserializing objects without allocating the intermediate byte vector like:
Especially useful for libraries like rust_bitcoincore_rpc in places like this https://github.com/rust-bitcoin/rust-bitcoincore-rpc/blob/54a427f2e45b0b8712d44a6995f6a03ad5f961f8/client/src/client.rs#L322-L326
CI is failing on my repo I think for an unrelated reason I am not fully grasping at the moment, @JeremyRubin could you have a look?