This repository was archived by the owner on Nov 30, 2022. It is now read-only.
Merged
Conversation
In preparation for being able to run `clippy` in the CI pipeline; add a config file that configures `clippy` with our current MSRV.
Clippy emits: warning: redundant field names in struct initialization Use field init shorthand.
Clippy emits: warning: unneeded late initalization As suggested use a single statement to declare and set the local `inner` variable.
To keep the codebase nice and clean we can run `clippy` as part of the CI pipeline. Enable `clippy` in a CI job.
apoelstra
approved these changes
May 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable running
clippyon CI, involves doing:clippywarningsclippy