You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Nov 30, 2022. It is now read-only.
IMHO this requires only a minor version bump since it strictly increases the set of things that can be deserialized.
Prior to this PR we would attempt to deserialize hashes first as &[u8], which we would copy into the hash type. The Deserialize impl for &[u8] uses a Visitor object that can only handle "borrowed bytes" (which are slices with a sufficiently long lifetime that they can be returned to callers; compare "bytes", which are also borrowed, but which are not assumed to outlive the invocation of Visitor::visit_bytes).
We don't need our byteslices to live long enough to to be returned, since we just copy the bytes into a new Hash object and return that. So we implement our own visitor which does exactly the same thing as before, but implements visit_bytes rather than visit_borrowed_bytes (and the default impl of visit_borrowed_bytes will fallthrough to visit_bytes).
This is needed to roundtrip using serde_cbor and probably other binary deserializiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.