This repository was archived by the owner on Nov 30, 2022. It is now read-only.
hex: allow specifying a width when printing hashes#9
Merged
Conversation
sgeisler
reviewed
Dec 13, 2018
sgeisler
reviewed
Dec 13, 2018
apoelstra
force-pushed
the
2018-11-truncated-hex
branch
from
d37a4ee to
012d775
Compare
Member
Author
|
Rebased and added commit to separate out "width" from "precision". @sgeisler can you re-review? |
sgeisler
approved these changes
May 4, 2019
Contributor
sgeisler
left a comment
sgeisler
left a comment
There was a problem hiding this comment.
LGTM. I think the concurrent usage of precision and width might lead to strange behavior, but imo nobody will (nor should they) do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.