Avoid allocation in build_scriptint#1033
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jun 3, 2022
Merged
Conversation
Member
|
I like this approach -- but I think there's a more elegant way to do this, where |
tcharding
approved these changes
Jun 3, 2022
Comment on lines
-1109
to
+1117
| use super::build_scriptint; | ||
| use super::write_scriptint; |
Member
There was a problem hiding this comment.
We can just delete these lines, wildcard import right above :) Probably not worth requiring re-acks just to do this though.
ChallengeDev210
pushed a commit
to ChallengeDev210/rust-bitcoin
that referenced
this pull request
Aug 1, 2022
…tint c80dbc2 Avoid allocation in build_scriptint (Steven Roose) Pull request description: Hehe, reason for party, let's invite apoelstra ! ACKs for top commit: apoelstra: ACK c80dbc2 tcharding: ACK c80dbc2 Tree-SHA512: 8446e765d8b9fa562f636817327db6fad4bb9c906d3f69fda76e61cd258fc4c296e6ffaa440a357125c2ab45603eb05c58cb8d6822deea2fe5746e5c7c3f1e4d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hehe, reason for party, let's invite apoelstra !