Skip to content

key: Impl From<secp256k1::PublicKey> for bitcoin::PublicKey#1949

Merged
apoelstra merged 2 commits intorust-bitcoin:masterfrom
stevenroose:key-from-secp
Jul 21, 2023
Merged

key: Impl From<secp256k1::PublicKey> for bitcoin::PublicKey#1949
apoelstra merged 2 commits intorust-bitcoin:masterfrom
stevenroose:key-from-secp

Conversation

@stevenroose
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ebcce38

@apoelstra
Copy link
Copy Markdown
Member

This may be mildly controversial since it could cause confusing behavior for somebody who cares about compressedness. But I think that set is pretty-much nobody today, so it's fine by me.

Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ebcce38

I'm getting super itchy to improve the state of affairs re keys.

@apoelstra apoelstra merged commit f50bb05 into rust-bitcoin:master Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants