Feature: Instruction can read the script number

[junderw]

This new method on Instruction will allow for interpreting the Instruction as a script number (i64)

[apoelstra]

Looks good! But we have an existing read_scriptint function that I think can do the PushBytes case. (Or did you check that it wasn't applicable for some reason?)

Could you also add a unit test for a couple negative zeros :}?

[apoelstra]

Ok, c7ff61d072d35562fe15850b4f9631e08afdc2e6 looks good now! But what do you think of renaming read_scriptint_internal to read_scriptint_nonminimal?

[junderw]

Should I expose it publicly?

In which case, we'd still want the > 4 byte check for both.

[apoelstra]

@junderw yeah, I think it should be exposed publicly.

[junderw]

Should be good for re-review now.

[apoelstra]

ACK 3bdef424f4e6aeb3f2ea8859b26f984148ba34e5

[junderw]

If tests pass, this is ready for re-review

[tcharding]

Ouch, CI fail is linter because if v.len() == 0 should be if v.is_empty().

Scond time this week my review suggestions have failed to build, bad robot.

[tcharding]

ACK 767b94e48dd2dfaaf21c598ec9fe395014c66c04

Thanks for working in my suggestions, appreciate the extra effort.

[tcharding]

ACK cd15c74

[apoelstra]

ACK cd15c74

[stevenroose]

Nice, this is useful!

Scond time this week my review suggestions have failed to build, bad robot.

You mean lint* not build ;)