Skip to content

Commit 5e752c9

Browse files
committed
Address PR review
1 parent 3196dd0 commit 5e752c9

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

Cargo.toml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,11 @@ rust_backend = ["miniz_oxide", "any_impl"]
6363
## Use the system's installed zlib library.
6464
## This is useful when you need compatibility with other C code that uses zlib,
6565
## or when you want to use the system-provided zlib for consistency.
66-
zlib = ["any_zlib", "any_c_zlib", "libz-sys"]
66+
zlib = ["any_c_zlib", "libz-sys"]
6767

6868
## Use the system's installed zlib library with default features enabled.
6969
## Similar to `zlib` but enables additional features from libz-sys.
70-
zlib-default = ["any_zlib", "any_c_zlib", "libz-sys/default"]
70+
zlib-default = ["any_c_zlib", "libz-sys/default"]
7171

7272
## Use zlib-ng in zlib-compat mode via libz-sys.
7373
## This provides zlib-ng's performance improvements while maintaining compatibility.
@@ -78,18 +78,18 @@ zlib-default = ["any_zlib", "any_c_zlib", "libz-sys/default"]
7878
## See [the libz-sys README](https://github.com/rust-lang/libz-sys/blob/main/README.md) for details.
7979
## To avoid that, use the `"zlib-ng"` feature instead.
8080

81-
zlib-ng-compat = ["any_zlib", "zlib", "libz-sys/zlib-ng"]
81+
zlib-ng-compat = ["zlib", "libz-sys/zlib-ng"]
8282

8383
## Use the high-performance zlib-ng library directly.
8484
## This typically provides better performance than stock zlib and works even when
8585
## other dependencies use zlib. Requires a C compiler.
86-
zlib-ng = ["any_zlib", "any_c_zlib", "libz-ng-sys"]
86+
zlib-ng = ["any_c_zlib", "libz-ng-sys"]
8787

8888
## Use Cloudflare's optimized zlib implementation.
8989
## This provides better performance than stock zlib on x86-64 (with SSE 4.2) and ARM64 (with NEON & CRC).
9090
## * ⚠ Does not support 32-bit CPUs and is incompatible with mingw.
9191
## * ⚠ May cause conflicts if other crates use different zlib versions.
92-
cloudflare_zlib = ["any_zlib", "any_c_zlib", "cloudflare-zlib-sys"]
92+
cloudflare_zlib = ["any_c_zlib", "cloudflare-zlib-sys"]
9393

9494
## Deprecated alias for `rust_backend`, provided for backwards compatibility.
9595
## Use `rust_backend` instead.
@@ -107,7 +107,7 @@ any_zlib = ["any_impl"]
107107
## **Internal:** Marker feature indicating that any C based fully zlib compatible backend is enabled.
108108
## This is automatically enabled by `zlib`, `zlib-ng`, `zlib-ng-compat`, and `cloudflare_zlib`.
109109
## Do not enable this feature directly; instead, choose a specific backend feature.
110-
any_c_zlib = ["any_impl"]
110+
any_c_zlib = ["any_zlib"]
111111

112112
## **Internal:** Marker feature indicating that any compression backend is enabled.
113113
## This is automatically enabled by all backend features to ensure at least one implementation is available.

src/ffi/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ mod c;
6565
#[cfg(feature = "any_c_zlib")]
6666
pub use self::c::*;
6767

68-
// Prefer C backes when both Rust backends are enabled to avoid duplicate exports.
68+
// Only bring in `zlib-rs` if there is no C-based backend.
6969
#[cfg(all(not(feature = "any_c_zlib"), feature = "zlib-rs"))]
7070
mod zlib_rs;
7171
#[cfg(all(not(feature = "any_c_zlib"), feature = "zlib-rs"))]
7272
pub use self::zlib_rs::*;
7373

74-
// Use to miniz_oxide when no fully compliant zlib is selected.
74+
// Use miniz_oxide when no fully compliant zlib is selected.
7575
#[cfg(all(not(feature = "any_zlib"), feature = "miniz_oxide"))]
7676
mod miniz_oxide;
7777
#[cfg(all(not(feature = "any_zlib"), feature = "miniz_oxide"))]

0 commit comments

Comments
 (0)