Skip to content

Commit 2d2c580

Browse files
committed
signed_data: update stale ring-specific rationale and parameter names in verify()
1 parent 3396bba commit 2d2c580

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

src/signed_data.rs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,11 @@ impl<'a> SignedData<'a> {
137137
}
138138

139139
/// Verify `signed_data` using the public key in the DER-encoded
140-
/// SubjectPublicKeyInfo `spki` using one of the algorithms in
140+
/// SubjectPublicKeyInfo `spki_value` using one of the algorithms in
141141
/// `supported_algorithms`.
142142
///
143143
/// The algorithm is chosen based on the algorithm information encoded in the
144-
/// algorithm identifiers in `public_key` and `signed_data.algorithm`. The
144+
/// algorithm identifiers in `spki_value` and `signed_data.algorithm`. The
145145
/// ordering of the algorithms in `supported_algorithms` does not really matter,
146146
/// but generally more common algorithms should go first, as it is scanned
147147
/// linearly for matches.
@@ -154,13 +154,13 @@ impl<'a> SignedData<'a> {
154154
budget.consume_signature()?;
155155

156156
// We need to verify the signature in `signed_data` using the public key
157-
// in `public_key`. In order to know which *ring* signature verification
158-
// algorithm to use, we need to know the public key algorithm (ECDSA,
157+
// in `spki_value`. In order to know which `SignatureVerificationAlgorithm`
158+
// to use, we need to know the public key algorithm (ECDSA,
159159
// RSA PKCS#1, etc.), the curve (if applicable), and the digest algorithm.
160160
// `signed_data` identifies only the public key algorithm and the digest
161-
// algorithm, and `public_key` identifies only the public key algorithm and
161+
// algorithm, and `spki_value` identifies only the public key algorithm and
162162
// the curve (if any). Thus, we have to combine information from both
163-
// inputs to figure out which `ring::signature::VerificationAlgorithm` to
163+
// inputs to figure out which `SignatureVerificationAlgorithm` to
164164
// use to verify the signature.
165165
//
166166
// This is all further complicated by the fact that we don't have any

0 commit comments

Comments
 (0)