fix: Prevent npm from symlinking local packages

Author: ryaninvents

src/__tests__/__snapshots__/index.test.js.snap

@@ -1,5 +1,15 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`@ryaninvents/plugin-bundle-dependencies should correctly resolve local dependencies 1`] = `
+Array [
+  "test-library",
+  "test-library/index.js",
+  "test-library/package.json",
+  "test-library/src",
+  "test-library/src/index.js",
+]
+`;
+
 exports[`@ryaninvents/plugin-bundle-dependencies should create a zip file with node_modules 1`] = `
 Array [
   "is-sorted",

src/__tests__/index.test.js

@@ -107,6 +107,18 @@ describe('@ryaninvents/plugin-bundle-dependencies', () => {
       .not.toThrow();
     const contents = String(await fs.readFile(`${mainProj.workingDir}/node_modules/test-library/index.js`));
     expect(contents).toBe('// Hello world');
+
+    await execa('npm', ['run', 'build'], {
+      env: { NODE_ENV: 'production' },
+      cwd: mainProj.workingDir
+    });
+    const archiveEntries = await new Promise((resolve, reject) => {
+      archive.list(`${mainProj.workingDir}/pkg/dist-dependencies.zip`, (err, results) => {
+        if (err) return reject(err);
+        return resolve(results.map(file => file.getPath()).sort());
+      });
+    });
+    expect(archiveEntries).toMatchSnapshot();
   }, 60e3);
 
   it('should create a zip file with node_modules', async () => {

src/util.js

@@ -5,6 +5,14 @@ import fs from 'fs-extra';
 
 const LOCAL_PACKAGE_PREFIX = 'file:';
 
+export async function npmPack (pkgPath, workingDir) {
+  const { stdout } = await execa('npm', ['pack', '--json', pkgPath], {
+    cwd: workingDir
+  });
+  const [output] = JSON.parse(stdout);
+  return resolve(workingDir, output.filename);
+}
+
 export function getPackageManagerCommand ({ cwd, options }) {
   if (options.packageManager) {
     const { packageManager } = options;
@@ -34,12 +42,16 @@ export function getPackageManagerCommand ({ cwd, options }) {
 
 export async function createManifest (tempdir, { cwd, manifest }) {
   const updatedManifest = { ...manifest };
+  const originalDeps = manifest.dependencies || {};
+  updatedManifest.dependencies = { ...originalDeps };
 
-  Object.keys(manifest.dependencies).forEach((pkgName) => {
-    const pkgVersion = manifest.dependencies[pkgName];
+  await Promise.all(Object.keys(originalDeps).map(async (pkgName) => {
+    const pkgVersion = originalDeps[pkgName];
     if (!pkgVersion.startsWith(LOCAL_PACKAGE_PREFIX)) return;
-    updatedManifest.dependencies[pkgName] = `${LOCAL_PACKAGE_PREFIX}${resolve(cwd, pkgVersion.slice(LOCAL_PACKAGE_PREFIX.length))}`;
-  });
+    const absolutePath = resolve(cwd, pkgVersion.slice(LOCAL_PACKAGE_PREFIX.length));
+    const bundledAbsolutePath = await npmPack(absolutePath, cwd);
+    updatedManifest.dependencies[pkgName] = `${LOCAL_PACKAGE_PREFIX}${bundledAbsolutePath}`;
+  }));
 
   await fs.writeFile(resolve(tempdir, 'package.json'), JSON.stringify(updatedManifest, null, 2));
 }