Skip to content

Commit 4f21baa

Browse files
committed
fix build issues
1 parent df2ec09 commit 4f21baa

8 files changed

Lines changed: 25 additions & 24 deletions

File tree

contracts/Safe.sol

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,14 @@ contract Safe is
5656
string public constant override VERSION = "1.5.0";
5757

5858
/**
59-
* @notice The precomputed EIP-712 domain separator hash for Safe typed data hashing and signing.
60-
* @dev Precomputed value of: `keccak256("EIP712Domain(uint256 chainId,address verifyingContract)")`.
59+
* @dev The precomputed EIP-712 domain separator hash for Safe typed data hashing and signing.
60+
* Precomputed value of: `keccak256("EIP712Domain(uint256 chainId,address verifyingContract)")`.
6161
*/
6262
bytes32 private constant DOMAIN_SEPARATOR_TYPEHASH = 0x47e79534a245952e8b16893a336b85a3d9ea9fa8c573f3d803afb92a79469218;
6363

6464
/**
65-
* @notice The precomputed EIP-712 type hash for the Safe transaction type.
66-
* @dev Precomputed value of: `keccak256("SafeTx(address to,uint256 value,bytes data,uint8 operation,uint256 safeTxGas,uint256 baseGas,uint256 gasPrice,address gasToken,address refundReceiver,uint256 nonce)")`.
65+
* @dev The precomputed EIP-712 type hash for the Safe transaction type.
66+
* Precomputed value of: `keccak256("SafeTx(address to,uint256 value,bytes data,uint8 operation,uint256 safeTxGas,uint256 baseGas,uint256 gasPrice,address gasToken,address refundReceiver,uint256 nonce)")`.
6767
*/
6868
bytes32 private constant SAFE_TX_TYPEHASH = 0xbb8310d486368db6bd6f849402fdd73ad53d316b5a4b2644ad6efe0f941286d8;
6969

@@ -73,8 +73,8 @@ contract Safe is
7373
uint256 public override nonce;
7474

7575
/**
76-
* @notice Deprecated precomputed domain separator.
77-
* @dev This deprecated storage variable is no longer in use but remains declared for storage layout compatibility across Safe versions.
76+
* @dev Deprecated precomputed domain separator.
77+
* It is no longer in use but remains declared for storage layout compatibility across Safe versions.
7878
*/
7979
bytes32 private _deprecatedDomainSeparator;
8080

contracts/accessors/SimulateTxAccessor.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {Executor, Enum} from "../base/Executor.sol";
1010
*/
1111
contract SimulateTxAccessor is Executor {
1212
/**
13-
* @notice The address of the {SimulateTxAccessor} contract.
13+
* @dev The address of the {SimulateTxAccessor} contract.
1414
*/
1515
address private immutable ACCESSOR_SINGLETON;
1616

contracts/base/FallbackManager.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import {IFallbackManager} from "../interfaces/IFallbackManager.sol";
1010
*/
1111
abstract contract FallbackManager is SelfAuthorized, IFallbackManager {
1212
/**
13-
* @notice The storage slot used for storing the currently configured fallback handler address.
14-
* @dev Precomputed value of: `keccak256("fallback_manager.handler.address")`.
13+
* @dev The storage slot used for storing the currently configured fallback handler address.
14+
* Precomputed value of: `keccak256("fallback_manager.handler.address")`.
1515
*/
1616
bytes32 internal constant FALLBACK_HANDLER_STORAGE_SLOT = 0x6c9a6c4a39284e37ed1cf53d337577d14212a4870fb976a4366c693b939918d5;
1717

contracts/base/GuardManager.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ abstract contract BaseTransactionGuard is ITransactionGuard {
7070
*/
7171
abstract contract GuardManager is SelfAuthorized, IGuardManager {
7272
/**
73-
* @notice The storage slot used for storing the currently configured transaction guard.
74-
* @dev Precomputed value of: `keccak256("guard_manager.guard.address")`.
73+
* @dev The storage slot used for storing the currently configured transaction guard.
74+
* Precomputed value of: `keccak256("guard_manager.guard.address")`.
7575
*/
7676
bytes32 internal constant GUARD_STORAGE_SLOT = 0x4a204f620c8c5ccdca3fd54d003badd85ba500436a431f0cbda4f558c93c34c8;
7777

contracts/base/ModuleManager.sol

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,22 +63,22 @@ abstract contract BaseModuleGuard is IModuleGuard {
6363
*/
6464
abstract contract ModuleManager is SelfAuthorized, Executor, IModuleManager {
6565
/**
66-
* @notice The sentinel module value in the {modules} linked list.
67-
* @dev `SENTINEL_MODULES` is used to traverse {modules}, so that:
66+
* @dev The sentinel module value in the {modules} linked list.
67+
* `SENTINEL_MODULES` is used to traverse {modules}, such that:
6868
* 1. `modules[SENTINEL_MODULES]` contains the first module
6969
* 2. `modules[last_module]` points back to `SENTINEL_MODULES`
7070
*/
7171
address internal constant SENTINEL_MODULES = address(0x1);
7272

7373
/**
74-
* @notice The storage slot used for storing the currently configured module guard.
75-
* @dev Precomputed value of: `keccak256("module_manager.module_guard.address")`.
74+
* @dev The storage slot used for storing the currently configured module guard.
75+
* Precomputed value of: `keccak256("module_manager.module_guard.address")`.
7676
*/
7777
bytes32 internal constant MODULE_GUARD_STORAGE_SLOT = 0xb104e0b93118902c651344349b610029d694cfdec91c589c91ebafbcd0289947;
7878

7979
/**
80-
* @notice The linked list of modules.
81-
* @dev This mapping defines a linked list where while allowing for `O(1)` inclusion checks.
80+
* @dev The linked list of modules, where `modules[module]` points to the next in the list.
81+
* A mapping is used to allow for `O(1)` inclusion checks.
8282
*/
8383
mapping(address => address) internal modules;
8484

contracts/base/OwnerManager.sol

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,26 +13,26 @@ import {IOwnerManager} from "../interfaces/IOwnerManager.sol";
1313
*/
1414
abstract contract OwnerManager is SelfAuthorized, IOwnerManager {
1515
/**
16-
* @notice The sentinel owner value in the {owners} linked list.
17-
* @dev `SENTINEL_OWNERS` is used to traverse {owners}, so that:
16+
* @dev The sentinel owner value in the {owners} linked list.
17+
* `SENTINEL_OWNERS` is used to traverse {owners}, such that:
1818
* 1. `owners[SENTINEL_OWNERS]` contains the first owner
1919
* 2. `owners[last_owner]` points back to `SENTINEL_OWNERS`
2020
*/
2121
address internal constant SENTINEL_OWNERS = address(0x1);
2222

2323
/**
24-
* @notice The linked list of owners.
25-
* @dev This mapping defines a linked list where while allowing for `O(1)` inclusion checks.
24+
* @dev The linked list of owners, where `owners[owner]` points to the next in the list.
25+
* A mapping is used to allow for `O(1)` inclusion checks.
2626
*/
2727
mapping(address => address) internal owners;
2828

2929
/**
30-
* @notice The number of owners.
30+
* @dev The number of owners.
3131
*/
3232
uint256 internal ownerCount;
3333

3434
/**
35-
* @notice The threshold of owners required to sign a transaction.
35+
* @dev The threshold of owners required to sign a transaction.
3636
*/
3737
uint256 internal threshold;
3838

contracts/interfaces/IModuleManager.sol

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import {Enum} from "../libraries/Enum.sol";
55
/**
66
* @title IModuleManager - An interface of contract managing Safe modules
77
* @notice Modules are extensions with unlimited access to a Safe that can be added to a Safe by its owners.
8-
⚠️ WARNING: Modules are a security risk since they can execute arbitrary transactions,
8+
⚠️ WARNING: Modules are a security risk since they can execute arbitrary transactions,
99
so only trusted and audited modules should be added to a Safe. A malicious module can
1010
completely takeover a Safe.
1111
* @author @safe-global/safe-protocol

contracts/interfaces/ISafe.sol

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ interface ISafe is IModuleManager, IGuardManager, IOwnerManager, IFallbackManage
176176
* @notice Returns a descriptive version of the Safe contract.
177177
* @return The version string.
178178
*/
179+
// solhint-disable-next-line func-name-mixedcase
179180
function VERSION() external view returns (string memory);
180181

181182
/**

0 commit comments

Comments
 (0)