Merged
Conversation
I noticed that transistive dependencies weren't updated in the previous PR, so I did so with `npm update`. I also updated to the latest `hardhat-deploy` (and am not sure why it was excluded from the previous PR as things seem to work as expected - maybe @mmv08 knows?).
mmv08
approved these changes
Apr 10, 2025
Contributor
I'm scared of hardhat-deploy (just look at the code, it is very complex). So if it works, I'd better not touch it. Especially with a major version upgrade |
Collaborator
Author
|
Are you OK with updating it here? It seems to work (and so did the Edit: assuming you are OK with the update because of the approval - I appreciate the caution though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that transistive dependencies weren't updated in the previous PR, so I did so with
npm update. I also updated to the latesthardhat-deploy(and am not sure why it was excluded from the previous PR as things seem to work as expected - maybe @mmv08 knows?).