Skip to content

Commit f414853

Browse files
Trottsagitsofan
authored andcommitted
doc: shorten pull request wait time to 48 hours
Currently, we have a 72 rule for how many hours a pull request should be left open at a minimum. Reduce that time to 48 hours. PR-URL: nodejs#23082 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
1 parent 5932fba commit f414853

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

doc/onboarding.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,8 @@ needs to be pointed out separately during the onboarding.
215215
labels.
216216
* Run CI on the PR. Because the PR does not affect any code, use the
217217
`node-test-pull-request-lite-pipeline` CI task.
218-
* After two Collaborator approvals for the change and two Collaborator approvals
219-
for fast-tracking, land the PR.
218+
* After one or two approvals, land the PR (PRs of this type do not need to wait
219+
for 48 hours to land).
220220
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:`
221221
metadata.
222222
* [`node-core-utils`][] automates the generation of metadata and the landing

0 commit comments

Comments
 (0)