Skip to content

Commit 7cecf86

Browse files
committed
Add missing icons to empty state cards
Add contextual icons to 4 EmptyState usages that were falling back to the generic Inbox icon: Zap for jobs, Settings for JM config, GitBranch for job graph, ArrowLeftRight for deployments. Replace custom inline empty state in deployments-table with shared EmptyState component.
1 parent c3162b5 commit 7cecf86

File tree

5 files changed

+13
-11
lines changed

5 files changed

+13
-11
lines changed

dashboard/src/components/deployments/deployments-table.tsx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
import { EmptyState } from "@flink-reactor/ui"
12
import { Link } from "@tanstack/react-router"
3+
import { ArrowLeftRight } from "lucide-react"
24
import type { BlueGreenDeployment } from "@flink-reactor/ui"
35
import { StateBadge } from "./state-badge"
46

@@ -9,13 +11,11 @@ interface DeploymentsTableProps {
911
export function DeploymentsTable({ deployments }: DeploymentsTableProps) {
1012
if (deployments.length === 0) {
1113
return (
12-
<div className="flex flex-col items-center justify-center py-16 text-zinc-500">
13-
<p className="text-sm">No blue-green deployments found</p>
14-
<p className="mt-1 text-xs">
15-
Configure Kubernetes access to monitor FlinkBlueGreenDeployment
16-
resources
17-
</p>
18-
</div>
14+
<EmptyState
15+
icon={ArrowLeftRight}
16+
title="No blue-green deployments found"
17+
description="Configure Kubernetes access to monitor FlinkBlueGreenDeployment resources"
18+
/>
1919
)
2020
}
2121

dashboard/src/components/job-manager/jm-config-section.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ export function JmConfigSection({ config }: { config: JobManagerConfig[] }) {
177177
</tbody>
178178
</table>
179179
{filtered.length === 0 && (
180-
<EmptyState message="No configuration entries" />
180+
<EmptyState icon={Settings} message="No configuration entries" />
181181
)}
182182
</div>
183183

dashboard/src/components/jobs/jobs-table.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import {
2626
Check,
2727
Copy,
2828
Radio,
29+
Zap,
2930
XCircle,
3031
} from "lucide-react"
3132
import { useCallback, useMemo, useState } from "react"
@@ -290,6 +291,7 @@ export function JobsTable({
290291
if (jobs.length === 0) {
291292
return (
292293
<EmptyState
294+
icon={Zap}
293295
message={isRunning ? "No running jobs" : "No matching jobs"}
294296
/>
295297
)

dashboard/src/components/overview/job-list.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import { Link, useNavigate } from "@tanstack/react-router"
2222
import { formatDistanceToNow } from "date-fns"
2323
import {
2424
ArrowRight,
25-
Briefcase,
25+
Zap,
2626
Radio,
2727
} from "lucide-react"
2828
import { useMemo, useState } from "react"
@@ -181,7 +181,7 @@ export function JobList({
181181
</div>
182182

183183
{visible.length === 0 ? (
184-
<EmptyState icon={Briefcase} message="No jobs found" />
184+
<EmptyState icon={Zap} message="No jobs found" />
185185
) : (
186186
<Table>
187187
<TableHeader>

packages/ui/src/templates/jobs/job-graph-section.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ const statusDotColor: Record<string, string> = {
6262
export function JobGraphSection({ job }: { job: FlinkJob }) {
6363
const plan = job.plan
6464
if (!plan || plan.vertices.length === 0) {
65-
return <EmptyState message="No execution plan available" />
65+
return <EmptyState icon={GitBranch} message="No execution plan available" />
6666
}
6767

6868
const vertexMap = new Map(plan.vertices.map((v) => [v.id, v]))

0 commit comments

Comments
 (0)