MAINT: Fixed whatever cargo clippy told me

Author: elichai

enigma-core/app/src/main.rs

@@ -11,7 +11,7 @@ extern crate rocksdb;
 #[macro_use]
 extern crate lazy_static;
 // networking apt install libzmq3-dev
-#[macro_use]
+#[cfg_attr(test, macro_use)]
 extern crate serde_json;
 extern crate zmq;
 // errors

enigma-core/app/src/wasm_u/wasm.rs

@@ -91,7 +91,7 @@ pub struct WasmResult {
     pub eth_contract_addr: [u8;20],
 }
 
-pub fn execute(eid: sgx_enclave_id_t,  bytecode: Box<[u8]>, callable: &str, args: &str)-> Result<WasmResult,Error>{
+pub fn execute(eid: sgx_enclave_id_t,  bytecode: &[u8], callable: &str, args: &str)-> Result<WasmResult,Error>{
     let mut retval: EnclaveReturn = EnclaveReturn::Success;
     let mut output = 0u64;
     let mut delta_data_ptr = 0u64;
@@ -195,7 +195,7 @@ pub mod tests {
         let enclave = init_enclave();
         let contract_code = compile_and_deploy_wasm_contract(enclave.geteid(), "../../examples/eng_wasm_contracts/simplest");
 //        let result = wasm::execute(enclave.geteid(),contract_code, "test(uint256,uint256)", "c20102").expect("Execution failed");
-        let result = wasm::execute(enclave.geteid(), contract_code, "write()", "").expect("Execution failed");
+        let result = wasm::execute(enclave.geteid(), &contract_code, "write()", "").expect("Execution failed");
         enclave.destroy();
         assert_eq!(from_utf8(&result.output).unwrap(), "\"157\"");
     }
@@ -204,7 +204,7 @@ pub mod tests {
     fn eth_bridge() {
         let enclave = init_enclave();
         let contract_code = compile_and_deploy_wasm_contract(enclave.geteid(), "../../examples/eng_wasm_contracts/contract_with_eth_calls");
-        let result = wasm::execute(enclave.geteid(), contract_code, "test()", "").expect("Execution failed");
+        let result = wasm::execute(enclave.geteid(), &contract_code, "test()", "").expect("Execution failed");
         enclave.destroy();
     }
 
@@ -220,7 +220,7 @@ pub mod tests {
         println!("Bytecode size: {}KB\n", wasm_code.len() / 1024);
         let enclave = init_enclave();
         let contract_code = wasm::deploy(enclave.geteid(), &wasm_code).expect("Deploy Failed");
-        let result = wasm::execute(enclave.geteid(),contract_code, "call", "").expect("Execution failed");
+        let result = wasm::execute(enclave.geteid(),&contract_code, "call", "").expect("Execution failed");
         assert_eq!(from_utf8(&result.output).unwrap(), "157");
     }
 }

enigma-tools-t/src/build_arguments_g/mod.rs

@@ -36,13 +36,13 @@ pub fn get_types(function: &str) -> Result<(String, String), EnclaveError>{
     Ok(( function[start_arg_index+1..end_arg_index].to_string(), String::from(&function[..start_arg_index] )))
 }
 
-pub fn get_args(callable_args: &[u8], types: &Vec<String>) -> Result<Vec<String>, EnclaveError>{
+pub fn get_args(callable_args: &[u8], types: &[String]) -> Result<Vec<String>, EnclaveError>{
     decode_args(callable_args, types)
 }
 
 pub fn extract_types(types: &str) -> Vec<String>{
     let mut types_vector: Vec<String> = vec![];
-    let types_iterator = types.split(",");
+    let types_iterator = types.split(',');
     for each_type in types_iterator{
         types_vector.push(each_type.to_string());
     }

enigma-tools-t/src/cryptography_t/asymmetric.rs

@@ -16,10 +16,7 @@ impl KeyPair {
         loop {
             let mut me: [u8; 32] = [0; 32];
             rsgx_read_rand(&mut me)?;
-            match SecretKey::parse(&me) {
-                Ok(_priv) => return Ok(KeyPair { privkey: _priv.clone(), pubkey: PublicKey::from_secret_key(&_priv) }),
-                Err(_) => (),
-            }
+            if let Ok(_priv) = SecretKey::parse(&me) { return Ok(KeyPair { privkey: _priv.clone(), pubkey: PublicKey::from_secret_key(&_priv) }) }
         }
     }
 

enigma-tools-u/src/web3_utils/w3utils.rs

@@ -3,7 +3,6 @@ use failure::Error;
 use hex::FromHex;
 use std::str;
 use std::time;
-use tiny_keccak::Keccak;
 //web3
 use web3;
 use web3::contract::tokens::Tokenize;