fix: could panic if http2 disabled but TLS negotiated h2 (#2194)

paolobarbolini · web-flow · commit 7a5df2126081 · 2024-03-20T17:02:00.000-04:00
The fix is only ask for h2 ALPN iff the http2 feature is enabled. Closes #2192
diff --git a/src/async_impl/client.rs b/src/async_impl/client.rs
@@ -590,7 +590,11 @@ impl ClientBuilder {
                             tls.alpn_protocols = vec!["h3".into()];
                         }
                         HttpVersionPref::All => {
-                            tls.alpn_protocols = vec!["h2".into(), "http/1.1".into()];
+                            tls.alpn_protocols = vec![
+                                #[cfg(feature = "http2")]
+                                "h2".into(),
+                                "http/1.1".into(),
+                            ];
                         }
                     }
 

Original file line number	Diff line number	Diff line change
`@@ -590,7 +590,11 @@ impl ClientBuilder {`
`590`	`590`	`tls.alpn_protocols = vec!["h3".into()];`
`591`	`591`	`}`
`592`	`592`	`HttpVersionPref::All => {`
`593`		`- tls.alpn_protocols = vec!["h2".into(), "http/1.1".into()];`
	`593`	`+ tls.alpn_protocols = vec![`
	`594`	`+ #[cfg(feature = "http2")]`
	`595`	`+ "h2".into(),`
	`596`	`+ "http/1.1".into(),`
	`597`	`+ ];`
`594`	`598`	`}`
`595`	`599`	`}`
`596`	`600`