add keyofStringsOnly

Author: silesky

packages/browser/src/core/user/index.ts

@@ -37,7 +37,6 @@ const defaults = {
 
 export type StoreType = 'cookie' | 'localStorage' | 'memory'
 
-type StringKeys<T> = Exclude<keyof T, number | symbol>
 type StorageObject = Record<string, unknown>
 
 class Store {
@@ -217,11 +216,11 @@ export class UniversalStorage<Data extends StorageObject = StorageObject> {
   }
 
   /*
-    This is to support few scenarios where:  
-    - value exist in one of the stores ( as a result of other stores being cleared from browser ) and we want to resync them 
+    This is to support few scenarios where:
+    - value exist in one of the stores ( as a result of other stores being cleared from browser ) and we want to resync them
     - read values in AJS 1.0 format ( for customers after 1.0 --> 2.0 migration ) and then re-write them in AJS 2.0 format
   */
-  public getAndSync<K extends StringKeys<Data>>(
+  public getAndSync<K extends keyof Data>(
     key: K,
     storeTypes?: StoreType[]
   ): Data[K] | null {
@@ -235,7 +234,7 @@ export class UniversalStorage<Data extends StorageObject = StorageObject> {
     ) as Data[K] | null
   }
 
-  public get<K extends StringKeys<Data>>(
+  public get<K extends keyof Data>(
     key: K,
     storeTypes?: StoreType[]
   ): Data[K] | null {
@@ -250,7 +249,7 @@ export class UniversalStorage<Data extends StorageObject = StorageObject> {
     return null
   }
 
-  public set<K extends StringKeys<Data>>(
+  public set<K extends keyof Data>(
     key: K,
     value: Data[K] | null,
     storeTypes?: StoreType[]
@@ -261,10 +260,7 @@ export class UniversalStorage<Data extends StorageObject = StorageObject> {
     return value
   }
 
-  public clear<K extends StringKeys<Data>>(
-    key: K,
-    storeTypes?: StoreType[]
-  ): void {
+  public clear<K extends keyof Data>(key: K, storeTypes?: StoreType[]): void {
     for (const store of this.getStores(storeTypes)) {
       store.remove(key)
     }

packages/browser/src/plugins/validation/index.ts

@@ -14,9 +14,7 @@ export function isFunction(obj: unknown): obj is Function {
   return typeof obj === 'function'
 }
 
-export function isPlainObject(
-  obj: unknown
-): obj is Record<string | symbol | number, any> {
+export function isPlainObject(obj: unknown): obj is Record<string, any> {
   return (
     Object.prototype.toString.call(obj).slice(8, -1).toLowerCase() === 'object'
   )

packages/core/src/validation/helpers.ts

@@ -12,9 +12,7 @@ export function isFunction(obj: unknown): obj is Function {
   return typeof obj === 'function'
 }
 
-export function isPlainObject(
-  obj: unknown
-): obj is Record<string | symbol | number, any> {
+export function isPlainObject(obj: unknown): obj is Record<string, any> {
   return (
     Object.prototype.toString.call(obj).slice(8, -1).toLowerCase() === 'object'
   )

tsconfig.json

@@ -4,6 +4,7 @@
     "esModuleInterop": true,
     "skipLibCheck": true,
     "noUnusedLocals": true,
+    "keyofStringsOnly": true,
     "noUnusedParameters": true
   },
   "ts-node": {