refactor/fix and clean core (#658)

Author: silesky

.changeset/selfish-pots-give.md

@@ -0,0 +1,5 @@
+---
+'@segment/analytics-core': patch
+---
+
+Clean up dead code.

packages/core-integration-tests/README.md

@@ -1,2 +1,5 @@
-Core tests that require AnalyticsBrowser, etc.
-This exists because we can't create circular dependencies -- so, for example, installing AnalyticsBrowser as a dev dependency on core.
+# Core Integration Tests
+This can contain a mix of tests which cover the public API of the package. This can range anywhere from typical integration tests that might stub out the API (which may or may not also be in the package itself), to tests around the specific npm packaged artifact. Examples include:
+- Is a license included in npm pack?
+- can you import a module (e.g. is the package.json path correctly to allow consumers to import)?
+- are there missing depenndencies in package.json?

packages/core-integration-tests/package.json

@@ -14,7 +14,6 @@
   "packageManager": "yarn@3.2.1",
   "devDependencies": {
     "@internal/config": "workspace:^",
-    "@segment/analytics-core": "workspace:^",
-    "@segment/analytics-next": "workspace:^"
+    "@segment/analytics-core": "workspace:^"
   }
 }

packages/core-integration-tests/src/plugins/middleware/index.test.ts

@@ -0,0 +1,6 @@
+import { CoreContext } from '@segment/analytics-core'
+
+it('should be able to import and instantiate some module from core', () => {
+  // Test the ability to do basic imports
+  expect(typeof new CoreContext({ type: 'alias' })).toBe('object')
+})

packages/core-integration-tests/src/public-api.test.ts

@@ -2,6 +2,8 @@
   "extends": "../../tsconfig.json",
   "exclude": ["node_modules", "dist"],
   "compilerOptions": {
+    "noUnusedLocals": false,
+    "noUnusedParameters": false,
     "module": "esnext",
     "target": "ES5",
     "moduleResolution": "node",