node: add configurable request timeout (#702)

Author: silesky

.changeset/empty-pets-behave.md

@@ -0,0 +1,5 @@
+---
+'@segment/analytics-core': patch
+---
+
+EventFactory should filter out option keys with undefined values

packages/core/src/events/__tests__/index.test.ts

@@ -1,6 +1,7 @@
 import { EventFactory } from '..'
 import { User } from '../../user'
 import { CoreSegmentEvent } from '../..'
+import { isDate } from 'lodash'
 
 describe('Event Factory', () => {
   let factory: EventFactory
@@ -379,4 +380,15 @@ describe('Event Factory', () => {
       })
     })
   })
+
+  it('should ignore undefined options', () => {
+    const event = factory.track(
+      'Order Completed',
+      { ...shoes },
+      { timestamp: undefined, traits: { foo: 123 } }
+    )
+
+    expect(typeof event.timestamp).toBe('object')
+    expect(isDate(event.timestamp)).toBeTruthy()
+  })
 })

packages/core/src/events/index.ts

@@ -8,6 +8,7 @@ import {
   CoreSegmentEvent,
   CoreOptions,
 } from './interfaces'
+import { pickBy } from '../utils/pick'
 import { validateEvent } from '../validation/assertions'
 
 interface EventFactorySettings {
@@ -222,6 +223,11 @@ export class EventFactory {
       {} as Record<string, boolean>
     )
 
+    // filter out any undefined options
+    event.options = pickBy(event.options || {}, (_, value) => {
+      return value !== undefined
+    })
+
     // This is pretty trippy, but here's what's going on:
     // - a) We don't pass initial integration options as part of the event, only if they're true or false
     // - b) We do accept per integration overrides (like integrations.Amplitude.sessionId) at the event level

packages/core/src/utils/pick.ts

@@ -0,0 +1,8 @@
+export const pickBy = <T, K extends keyof T>(
+  obj: T,
+  fn: (key: K, v: T[K]) => boolean
+) => {
+  return (Object.keys(obj) as K[])
+    .filter((k) => fn(k, obj[k]))
+    .reduce((acc, key) => ((acc[key] = obj[key]), acc), {} as Partial<T>)
+}

packages/node/package.json

@@ -40,7 +40,8 @@
   },
   "devDependencies": {
     "@internal/config": "0.0.0",
-    "@types/node": "^14"
+    "@types/node": "^14",
+    "nock": "^13.2.9"
   },
   "packageManager": "yarn@3.2.1"
 }