Remove node-fetch dependency from @segment/analytics-node (#1348)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: MichaelGHSeg

.changeset/remove-node-fetch.md

@@ -0,0 +1,5 @@
+---
+'@segment/analytics-node': major
+---
+
+Remove node-fetch dependency in favor of native globalThis.fetch (available since Node 18, package requires >= 20)

packages/node/package.json

@@ -40,7 +40,6 @@
     "@segment/analytics-generic-utils": "1.2.0",
     "buffer": "^6.0.3",
     "jose": "^5.1.0",
-    "node-fetch": "^2.6.7",
     "tslib": "^2.4.1"
   },
   "devDependencies": {

packages/node/src/__tests__/typedef-tests.ts

@@ -8,7 +8,6 @@ import {
   GroupTraits,
   HTTPClient,
   FetchHTTPClient,
-  HTTPFetchFn,
   HTTPClientRequest,
 } from '../'
 
@@ -90,10 +89,8 @@ export default {
     console.log({} as UserTraits)
   },
 
-  'HTTPFetchFn should be compatible with standard fetch and node-fetch interface, as well as functions':
+  'HTTPFetchFn should be compatible with standard fetch interface, as well as functions':
     () => {
-      const fetch: HTTPFetchFn = require('node-fetch')
-      new Analytics({ writeKey: 'foo', httpClient: fetch })
       new Analytics({ writeKey: 'foo', httpClient: globalThis.fetch })
     },
 

packages/node/src/app/settings.ts

@@ -43,7 +43,7 @@ export interface AnalyticsSettings {
   /**
    * Supply a default http client implementation (such as one supporting proxy).
    * Accepts either an HTTPClient instance or a fetch function.
-   * Default: an HTTP client that uses globalThis.fetch, with node-fetch as a fallback.
+   * Default: an HTTP client that uses globalThis.fetch.
    */
   httpClient?: HTTPFetchFn | HTTPClient
   /**

packages/node/src/lib/fetch.ts

@@ -1,16 +1,5 @@
 import type { HTTPFetchFn } from './http-client'
 
-export const fetch: HTTPFetchFn = async (...args) => {
-  if (globalThis.fetch) {
-    return globalThis.fetch(...args)
-  }
-  // This guard causes is important, as it causes dead-code elimination to be enabled inside this block.
-  // @ts-ignore
-  else if (typeof EdgeRuntime !== 'string') {
-    return (await import('node-fetch')).default(...args)
-  } else {
-    throw new Error(
-      'Invariant: an edge runtime that does not support fetch should not exist'
-    )
-  }
+export const fetch: HTTPFetchFn = (...args) => {
+  return globalThis.fetch(...args)
 }

packages/node/src/lib/http-client.ts

@@ -2,8 +2,7 @@ import { abortSignalAfterTimeout } from './abort'
 import { fetch as defaultFetch } from './fetch'
 
 /**
- * This interface is meant to be compatible with different fetch implementations (node and browser).
- * Using the ambient fetch type is not possible because the AbortSignal type is not compatible with node-fetch.
+ * This interface is meant to be compatible with different fetch implementations.
  * @link https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API
  */
 export interface HTTPFetchFn {
@@ -18,7 +17,7 @@ export interface HTTPFetchRequest {
   headers: Record<string, string>
   body: string
   method: HTTPClientRequest['method']
-  signal: any // AbortSignal type does not play nicely with node-fetch
+  signal: any
 }
 
 /**

yarn.lock

@@ -4459,7 +4459,6 @@ __metadata:
     axios: ^1.6.2
     buffer: ^6.0.3
     jose: ^5.1.0
-    node-fetch: ^2.6.7
     tslib: ^2.4.1
   languageName: unknown
   linkType: soft