cleanup tests and verify messageId

Author: chrisradek

packages/browser-integration-tests/src/segment-retries.test.ts

@@ -42,16 +42,16 @@ test.describe('Standalone tests', () => {
           times: 1,
         }
       )
-      const requestFailure = new Promise((resolve) => {
-        page.once('requestfailed', resolve)
+      const requestFailure = new Promise<Record<string, any>>((resolve) => {
+        page.once('requestfailed', (request) => resolve(request.postDataJSON()))
       })
 
       // trigger an event
       await page.evaluate(() => {
         void window.analytics.track('test event')
       })
 
-      await requestFailure
+      const { messageId } = await requestFailure
       await page.reload()
 
       // load analytics.js again and wait for a new request.
@@ -61,16 +61,14 @@ test.describe('Standalone tests', () => {
       ])
 
       expect(request.method()).toBe('POST')
+      expect(request.postDataJSON().messageId).toBe(messageId)
     })
 
     test('supports retrying in-flight requests on page navigation', async ({
       page,
     }) => {
       // Load analytics.js
       await page.goto('/standalone.html')
-      await page.evaluate(() =>
-        window.addEventListener('pagehide', () => console.log('hidden'))
-      )
       await page.evaluate(() => window.analytics.load('fake-key'))
 
       // blackhole the request so that it stays in-flight when we reload the page
@@ -85,11 +83,11 @@ test.describe('Standalone tests', () => {
       )
 
       // Detect when we've seen a track request initiated by the browser
-      const requestSent = new Promise<void>((resolve) => {
+      const requestSent = new Promise<Record<string, any>>((resolve) => {
         const onRequest: (req: Request) => void = (req) => {
           if (req.url() === 'https://api.segment.io/v1/t') {
             page.off('request', onRequest)
-            resolve()
+            resolve(req.postDataJSON())
           }
         }
 
@@ -101,7 +99,7 @@ test.describe('Standalone tests', () => {
         void window.analytics.track('test event')
       })
 
-      await requestSent
+      const { messageId } = await requestSent
       await page.reload()
 
       // load analytics.js again and wait for a new request.
@@ -111,6 +109,7 @@ test.describe('Standalone tests', () => {
       ])
 
       expect(request.method()).toBe('POST')
+      expect(request.postDataJSON().messageId).toBe(messageId)
     })
   })
 })