fs: validate mode in CreateReadStream and CreateWriteStream

 Large mode values (e.g. 2176057344) that exceed the Int32 range
  but fit within UInt32 cause a C++ assertion failure (args[2]->IsInt32())
  instead of throwing a RangeError.

  This is a regression introduced by nodejs#52050 which moved mode validation
  to C++. Fix by:
  1. Changing parseFileMode() to use validateInt32 instead of
     validateUint32 to match the C++ Int32 expectation.
  2. Adding parseFileMode() calls in ReadStream/WriteStream constructors.

  Fixes: nodejs#62516

Author: semimikoh

lib/internal/fs/streams.js

@@ -23,6 +23,7 @@ const {
   kEmptyObject,
 } = require('internal/util');
 const {
+  parseFileMode,
   validateBoolean,
   validateFunction,
   validateInteger,
@@ -181,7 +182,7 @@ function ReadStream(path, options) {
     // Path will be ignored when fd is specified, so it can be falsy
     this.path = toPathIfFileURL(path);
     this.flags = options.flags === undefined ? 'r' : options.flags;
-    this.mode = options.mode === undefined ? 0o666 : options.mode;
+    this.mode = parseFileMode(options.mode, 'options.mode', 0o666);
 
     validatePath(this.path);
   } else {
@@ -333,7 +334,7 @@ function WriteStream(path, options) {
     // Path will be ignored when fd is specified, so it can be falsy
     this.path = toPathIfFileURL(path);
     this.flags = options.flags === undefined ? 'w' : options.flags;
-    this.mode = options.mode === undefined ? 0o666 : options.mode;
+    this.mode = parseFileMode(options.mode, 'options.mode', 0o666);
 
     validatePath(this.path);
   } else {

lib/internal/validators.js

@@ -78,7 +78,7 @@ function parseFileMode(value, name, def) {
     value = NumberParseInt(value, 8);
   }
 
-  validateUint32(value, name);
+  validateInt32(value, name, 0);
   return value;
 }
 

test/parallel/test-file-validate-mode-flag.js

@@ -1,10 +1,13 @@
 'use strict';
 
 // Checks for crash regression: https://github.com/nodejs/node/issues/37430
+// and https://github.com/nodejs/node/issues/62516
 
 const common = require('../common');
 const assert = require('assert');
 const {
+  createReadStream,
+  createWriteStream,
   open,
   openSync,
   promises: {
@@ -15,6 +18,10 @@ const {
 // These should throw, not crash.
 const invalid = 4_294_967_296;
 
+// Value within UInt32 range but exceeding Int32 range.
+// Regression test for https://github.com/nodejs/node/issues/62516
+const invalidInt32 = 2_176_057_344;
+
 assert.throws(() => open(__filename, invalid, common.mustNotCall()), {
   code: 'ERR_OUT_OF_RANGE'
 });
@@ -23,6 +30,10 @@ assert.throws(() => open(__filename, 0, invalid, common.mustNotCall()), {
   code: 'ERR_OUT_OF_RANGE'
 });
 
+assert.throws(() => open(__filename, 0, invalidInt32, common.mustNotCall()), {
+  code: 'ERR_OUT_OF_RANGE'
+});
+
 assert.throws(() => openSync(__filename, invalid), {
   code: 'ERR_OUT_OF_RANGE'
 });
@@ -31,10 +42,36 @@ assert.throws(() => openSync(__filename, 0, invalid), {
   code: 'ERR_OUT_OF_RANGE'
 });
 
+assert.throws(() => openSync(__filename, 0, invalidInt32), {
+  code: 'ERR_OUT_OF_RANGE'
+});
+
 assert.rejects(openPromise(__filename, invalid), {
   code: 'ERR_OUT_OF_RANGE'
 }).then(common.mustCall());
 
 assert.rejects(openPromise(__filename, 0, invalid), {
   code: 'ERR_OUT_OF_RANGE'
 }).then(common.mustCall());
+
+assert.rejects(openPromise(__filename, 0, invalidInt32), {
+  code: 'ERR_OUT_OF_RANGE'
+}).then(common.mustCall());
+
+// createReadStream and createWriteStream should also validate mode.
+// Regression test for https://github.com/nodejs/node/issues/62516
+assert.throws(() => createReadStream(__filename, { mode: invalidInt32 }), {
+  code: 'ERR_OUT_OF_RANGE'
+});
+
+assert.throws(() => createWriteStream(__filename, { mode: invalidInt32 }), {
+  code: 'ERR_OUT_OF_RANGE'
+});
+
+assert.throws(() => createReadStream(__filename, { mode: invalid }), {
+  code: 'ERR_OUT_OF_RANGE'
+});
+
+assert.throws(() => createWriteStream(__filename, { mode: invalid }), {
+  code: 'ERR_OUT_OF_RANGE'
+});