Skip to content

Commit 3a5f412

Browse files
committed
Update orchestration/increase_default_stack_size.sh
I wrote and validated it against ShellCheck 0.9.0. It's now validated against ShellCheck 0.10.0.
1 parent dcebc36 commit 3a5f412

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

orchestration/increase_default_stack_size.sh

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,9 @@ write_bytes() {
4747

4848
# Magic
4949
MAGIC=$(read_bytes 0 4)
50+
OCTAL_7F=$(hex_to_octal 7f)
5051
# shellcheck disable=SC2059
51-
EXPECTED_MAGIC=$(printf \\"$(hex_to_octal 7f)"ELF | hex)
52+
EXPECTED_MAGIC=$(printf \\"$OCTAL_7F"ELF | hex)
5253
if [ ! "$MAGIC" = "$EXPECTED_MAGIC" ]; then
5354
echo "Not ELF"
5455
exit 2
@@ -130,13 +131,15 @@ if [ ! "$ELF_VERSION" = "01" ]; then
130131
fi
131132

132133
ELF_VERSION_2=$(read_bytes $((0x14)) 4)
133-
if [ ! "$ELF_VERSION_2" = "$(swap_native_endian 00000001)" ]; then
134+
NATIVE_ENDIAN_1_U32=$(swap_native_endian 00000001)
135+
if [ ! "$ELF_VERSION_2" = "$NATIVE_ENDIAN_1_U32" ]; then
134136
echo "Unknown secondary ELF Version ($ELF_VERSION_2)"
135137
exit 7
136138
fi
137139

138140
# Find where the program headers are
139-
PROGRAM_HEADERS_OFFSET=$(read_integer_by_offset 0x1c 0x20 "$(value_per_bits 4 8)")
141+
HEADERS_OFFSET_LEN=$(value_per_bits 4 8)
142+
PROGRAM_HEADERS_OFFSET=$(read_integer_by_offset 0x1c 0x20 "$HEADERS_OFFSET_LEN")
140143
PROGRAM_HEADER_SIZE=$(value_per_bits 0x20 0x38)
141144
DECLARED_PROGRAM_HEADER_SIZE=$(read_integer_by_offset 0x2a 0x36 2)
142145
if [ ! "$PROGRAM_HEADER_SIZE" -eq "$DECLARED_PROGRAM_HEADER_SIZE" ]; then

0 commit comments

Comments
 (0)