better testing

Author: severest

Gemfile

@@ -28,6 +28,7 @@ group :development, :test do
   gem 'capybara'
   gem 'selenium-webdriver'
   gem 'sqlite3'
+  gem 'factory_bot_rails'
 end
 
 group :development do

Gemfile.lock

@@ -82,6 +82,11 @@ GEM
     crass (1.0.4)
     docile (1.1.5)
     erubi (1.7.1)
+    factory_bot (4.8.2)
+      activesupport (>= 3.0.0)
+    factory_bot_rails (4.8.2)
+      factory_bot (~> 4.8.2)
+      railties (>= 3.0.0)
     ffi (1.9.23)
     globalid (0.4.1)
       activesupport (>= 4.2.0)
@@ -198,6 +203,7 @@ DEPENDENCIES
   capistrano3-puma
   capybara
   codeclimate-test-reporter
+  factory_bot_rails
   jbuilder
   listen
   mysql2

client/components/PrevDeltasModal/PrevDeltasModal.jsx

@@ -66,7 +66,7 @@ class PrevDeltasModal extends React.Component {
 
   render() {
     const modal = (
-      <div className="modal fade show in" tabIndex="-1" role="dialog">
+      <div className="modal fade show in js-test-prev-deltas-modal" tabIndex="-1" role="dialog">
         <div className="modal-dialog" role="document">
           <div className="modal-content">
             <div className="modal-body">
@@ -85,7 +85,7 @@ class PrevDeltasModal extends React.Component {
                     className={css(styles.deltaItem)}
                   >
                     <input
-                      className={css(styles.deltaItemCheck)}
+                      className={css(styles.deltaItemCheck) + ' js-test-prev-delta-check'}
                       type="checkbox"
                       selected={this.state.selected.includes(delta.id)}
                       onClick={() => this.handleCheckbox(delta.id)}

test/controllers/retro_controller_test.rb

@@ -48,15 +48,22 @@ class RetroControllerTest < ActionDispatch::IntegrationTest
     end
   end
 
+  test "should show retro" do
+    retro = create(:full_retro, key: 'abcdef')
+    get "/api/retro/#{retro.key}"
+    assert_response :success
+    json_response = JSON.parse(@response.body)
+    assert_equal retro.id, json_response['id']
+    assert_equal 'abcdef', json_response['key']
+    assert_equal 'in_progress', json_response['status']
+    assert_equal 5, json_response['deltas'].count
+    assert_equal 5, json_response['pluses'].count
+  end
+
   test "should show retro with previous deltas" do
     get "/api/retro/#{retros(:empty).key}"
     assert_response :success
     json_response = JSON.parse(@response.body)
-    assert_equal 2, json_response['id']
-    assert_equal 'jjj222', json_response['key']
-    assert_equal 'locked', json_response['status']
-    assert_equal 0, json_response['deltas'].count
-    assert_equal 0, json_response['pluses'].count
     assert_equal 2, json_response['prev_deltas'].count
   end
 

test/factories/deltas.rb

@@ -0,0 +1,5 @@
+FactoryBot.define do
+  factory :delta do
+    content "a delta"
+  end
+end

test/factories/pluses.rb

@@ -0,0 +1,5 @@
+FactoryBot.define do
+  factory :plus do
+    content "a plus"
+  end
+end

test/factories/retros.rb

@@ -0,0 +1,17 @@
+FactoryBot.define do
+  factory :retro do
+    status "in_progress"
+  end
+
+  factory :full_retro, parent: :retro do
+    transient do
+      delta_count 5
+      pluses_count 5
+    end
+
+    after(:create) do |retro, evaluator|
+      create_list(:delta, evaluator.delta_count, retro: retro)
+      create_list(:plus, evaluator.pluses_count, retro: retro)
+    end
+  end
+end

test/factories/teams.rb

@@ -0,0 +1,5 @@
+FactoryBot.define do
+  factory :team do
+    name "test team"
+  end
+end

test/system/.keep

@@ -0,0 +1,21 @@
+require "application_system_test_case"
+
+
+class RetrobotSystemTestCase < ApplicationSystemTestCase
+  def teardown
+    errors = page.driver.browser.manage.logs.get(:browser)
+    if errors.present?
+      message = errors.map(&:message).join("\n")
+      puts message
+    end
+    assert !errors.present?
+  end
+
+  def visit(url)
+    if !ENV['LOCAL_TESTING'].nil?
+      super 'http://localhost:8080' + url
+    else
+      super url
+    end
+  end
+end