Drop RC4 from the cipher list#551
Merged
shazow merged 1 commit intourllib3:masterfrom Feb 19, 2015
Merged
Conversation
In addition to having many security concerns, it is a violation of RFC 7465 to include RC4 cipher suites in a ClientHello.
Contributor
|
👍 |
Member
|
Thank you, @alex! You should add yourself to the CONTRIBUTORS.txt file one of these days for keeping our cipher suites fresh. :P |
Contributor
Author
|
✨ 🍰 I'll send a PR adding myself momentarily :-) |
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Mar 10, 2015
Changes
2.5.3 (2015-02-24)
Bugfixes
Revert changes to our vendored certificate bundle. For more context see (#2455, #2456, and http://bugs.python.org/issue23476)
2.5.2 (2015-02-23)
Features and Improvements
Add sha256 fingerprint support. (urllib3/urllib3#540)
Improve the performance of headers. (urllib3/urllib3#544)
Bugfixes
Copy pip’s import machinery. When downstream redistributors remove requests.packages.urllib3 the import machinery will continue to let those same symbols work. Example usage in requests’ documentation and 3rd-party libraries relying on the vendored copies of urllib3 will work without having to fallback to the system urllib3.
Attempt to quote parts of the URL on redirect if unquoting and then quoting fails. (#2356)
Fix filename type check for multipart form-data uploads. (#2411)
Properly handle the case where a server issuing digest authentication challenges provides both auth and auth-int qop-values. (#2408)
Fix a socket leak. (urllib3/urllib3#549)
Fix multiple Set-Cookie headers properly. (urllib3/urllib3#534)
Disable the built-in hostname verification. (urllib3/urllib3#526)
Fix the behaviour of decoding an exhausted stream. (urllib3/urllib3#535)
Security
Pulled in an updated cacert.pem.
Drop RC4 from the default cipher list. (urllib3/urllib3#551)
This was referenced Aug 17, 2016
This was referenced Oct 6, 2016
This was referenced Oct 18, 2016
This was referenced Oct 20, 2016
This was referenced Nov 15, 2016
This was referenced Oct 12, 2017
This was referenced Oct 23, 2017
This was referenced Nov 9, 2017
This was referenced Dec 23, 2017
This was referenced Dec 31, 2017
This was referenced Feb 6, 2018
This was referenced Mar 5, 2018
ghost
mentioned this pull request
butogon
approved these changes
Sep 17, 2022
Ousret
pushed a commit
to jawah/urllib3.future
that referenced
this pull request
Oct 2, 2025
Updates the requirements on [pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the latest version. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst">pytest-cov's changelog</a>.</em></p> <blockquote> <h2>7.0.0 (2025-09-09)</h2> <ul> <li> <p>Dropped support for subprocesses measurement.</p> <p>It was a feature added long time ago when coverage lacked a nice way to measure subprocesses created in tests. It relied on a <code>.pth</code> file, there was no way to opt-out and it created bad interations with <code>coverage's new patch system <https://coverage.readthedocs.io/en/latest/config.html#run-patch></code>_ added in <code>7.10 <https://coverage.readthedocs.io/en/7.10.6/changes.html#version-7-10-0-2025-07-24></code>_.</p> <p>To migrate to this release you might need to enable the suprocess patch, example for <code>.coveragerc</code>:</p> <p>.. code-block:: ini</p> <p>[run] patch = subprocess</p> <p>This release also requires at least coverage 7.10.6.</p> </li> <li> <p>Switched packaging to have metadata completely in <code>pyproject.toml</code> and use <code>hatchling <https://pypi.org/project/hatchling/></code>_ for building. Contributed by Ofek Lev in <code>[urllib3#551](pytest-dev/pytest-cov#551) <https://github.com/pytest-dev/pytest-cov/pull/551></code>_ with some extras in <code>[urllib3#716](pytest-dev/pytest-cov#716) <https://github.com/pytest-dev/pytest-cov/pull/716></code>_.</p> </li> <li> <p>Removed some not really necessary testing deps like <code>six</code>.</p> </li> </ul> <h2>6.3.0 (2025-09-06)</h2> <ul> <li>Added support for markdown reports. Contributed by Marcos Boger in <code>[urllib3#712](pytest-dev/pytest-cov#712) <https://github.com/pytest-dev/pytest-cov/pull/712></code>_ and <code>[urllib3#714](pytest-dev/pytest-cov#714) <https://github.com/pytest-dev/pytest-cov/pull/714></code>_.</li> <li>Fixed some formatting issues in docs. Anonymous contribution in <code>[urllib3#706](pytest-dev/pytest-cov#706) <https://github.com/pytest-dev/pytest-cov/pull/706></code>_.</li> </ul> <h2>6.2.1 (2025-06-12)</h2> <ul> <li> <p>Added a version requirement for pytest's pluggy dependency (1.2.0, released 2023-06-21) that has the required new-style hookwrapper API.</p> </li> <li> <p>Removed deprecated license classifier (packaging).</p> </li> <li> <p>Disabled coverage warnings in two more situations where they have no value:</p> <ul> <li>"module-not-measured" in workers</li> <li>"already-imported" in subprocesses</li> </ul> </li> </ul> <h2>6.2.0 (2025-06-11)</h2> <ul> <li> <p>The plugin now adds 3 rules in the filter warnings configuration to prevent common coverage warnings being raised as obscure errors::</p> <p>default:unclosed database in <sqlite3.Connection object at:ResourceWarning once::PytestCovWarning</p> </li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/224d8964caad90074a8cf6dc8720b8f70f31629b"><code>224d896</code></a> Bump version: 6.3.0 → 7.0.0</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/73424e3999f865eac72e27f09d5fe11b9703cfd6"><code>73424e3</code></a> Cleanup the docs a bit.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/36f1cc2967831dbd4c8aa70086fc86dc495f8b9a"><code>36f1cc2</code></a> Bump pins in template.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/f299c590a63a48e51e3ae949993dc7bb1f1d480d"><code>f299c59</code></a> Bump the github-actions group with 2 updates</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/25f0b2e0cdbc345c0d3e49170f7a328c3e0d805f"><code>25f0b2e</code></a> Update docs/config.rst</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/bb23eacc5531fb8f499213d8420407e0d72f88e3"><code>bb23eac</code></a> Improve configuration docs</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/a19531e91e1ab753ccf648a2d9bab08a6fddebb9"><code>a19531e</code></a> Switch from build/pre-commit to uv/prek - this should make this faster.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/82f999391073f2fb8ae422af452602f310086a2a"><code>82f9993</code></a> Update changelog.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/211b5cd41c29916bc643b4a11b00578ba4fd6fe8"><code>211b5cd</code></a> Fix links.</li> <li><a href="https://github.com/pytest-dev/pytest-cov/commit/97aadd74bcbc00a2078d240e8fe871dd62b83d80"><code>97aadd7</code></a> Update some ci config, reformat and apply some lint fixes.</li> <li>Additional commits viewable in <a href="https://github.com/pytest-dev/pytest-cov/compare/v4.0.0...v7.0.0">compare view</a></li> </ul> </details> <br /> Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to having many security concerns, it is a violation of RFC 7465 to include RC4 cipher suites in a ClientHello.