Fix cookie-session support for Express and add tests

Author: simov

lib/consumer/express.js

@@ -55,7 +55,7 @@ module.exports = function (_config) {
   }
 
   var redirect = (req, res, url) =>
-    typeof req.session.save === 'function'
+    typeof req.session.save === 'function' && req.session.save.length
       ? req.session.save(() => res.redirect(url))
       : res.redirect(url)
 

package.json

@@ -31,6 +31,7 @@
     "babel-polyfill": "^6.26.0",
     "babel-preset-env": "^1.7.0",
     "body-parser": "^1.18.3",
+    "cookie-session": "^1.3.3",
     "coveralls": "^3.0.3",
     "express": "^4.16.4",
     "express-session": "^1.15.6",

test/consumer/middleware.js

@@ -40,7 +40,7 @@ describe('middleware', () => {
       }
     }
 
-    ;['koa', 'koa-mount'].forEach((name) => {
+    ;['koa', 'koa-mount', 'express', 'express-cookie'].forEach((name) => {
       describe(name, () => {
         before(async () => {
           var obj = await client[name](config, port.app)

test/consumer/util/client.js

@@ -4,6 +4,7 @@ var qs = require('qs')
 
 var express = require('express')
 var session = require('express-session')
+var cookiesession = require('cookie-session')
 var bodyParser = require('body-parser')
 
 var Koa = require('koa')
@@ -44,6 +45,17 @@ module.exports = {
 
     var server = app.listen(port, () => resolve({grant, server, app}))
   }),
+  'express-cookie': (config, port) => new Promise((resolve) => {
+    var grant = Grant.express()(config)
+
+    var app = express()
+    app.use(bodyParser.urlencoded({extended: true}))
+    app.use(cookiesession({signed: true, secret: 'grant', maxAge: 60 * 1000}))
+    app.use(grant)
+    app.get('/', callback.express)
+
+    var server = app.listen(port, () => resolve({grant, server, app}))
+  }),
   koa: (config, port) => new Promise((resolve) => {
     var grant = Grant.koa()(config)