Validate some options better

Fixes #252

Author: sindresorhus

index.js

@@ -17,6 +17,8 @@ const SYNCHRONIZED_OUTPUT_DISABLE = '\u001B[?2026l';
 // Global state for concurrent spinner detection
 const activeHooksPerStream = new Map(); // Stream → ora instance
 
+const validColors = new Set(['black', 'red', 'green', 'yellow', 'blue', 'magenta', 'cyan', 'white', 'gray']);
+
 class Ora {
 	#linesToClear = 0;
 	#frameIndex = -1;
@@ -30,7 +32,7 @@ class Ora {
 	#drainHandler;
 	#deferRenderTimer;
 	#isDiscardingStdin = false;
-	color;
+	#color;
 
 	// Helper to execute writes while preventing hook recursion
 	#internalWrite(fn) {
@@ -141,6 +143,10 @@ class Ora {
 			this.#options.isSilent = false;
 		}
 
+		if (this.#options.interval !== undefined && !(Number.isInteger(this.#options.interval) && this.#options.interval > 0)) {
+			throw new Error('The `interval` option must be a positive integer');
+		}
+
 		// Set *after* `this.#stream`.
 		// Store original interval before spinner setter clears it
 		const userInterval = this.#options.interval;
@@ -286,6 +292,18 @@ class Ora {
 		return count;
 	}
 
+	get color() {
+		return this.#color;
+	}
+
+	set color(value) {
+		if (value !== undefined && value !== false && !validColors.has(value)) {
+			throw new Error('The `color` option must be a valid color or `false` to disable');
+		}
+
+		this.#color = value;
+	}
+
 	get isEnabled() {
 		return this.#options.isEnabled && !this.#options.isSilent;
 	}
@@ -321,8 +339,8 @@ class Ora {
 		const {frames} = this.#spinner;
 		let frame = frames[this.#frameIndex];
 
-		if (this.color) {
-			frame = chalk[this.color](frame);
+		if (this.#color) {
+			frame = chalk[this.#color](frame);
 		}
 
 		const fullPrefixText = this.#getFullPrefixText(this.#options.prefixText, ' ');

test.js

@@ -1567,6 +1567,57 @@ test('interval validation works correctly', () => {
 	assert.strictEqual(spinner2.interval, 150);
 });
 
+test('interval rejects negative values', () => {
+	assert.throws(() => {
+		ora({interval: -100});
+	}, {message: /positive integer/});
+});
+
+test('interval rejects non-integer values', () => {
+	assert.throws(() => {
+		ora({interval: 1.5});
+	}, {message: /positive integer/});
+});
+
+test('interval rejects zero', () => {
+	assert.throws(() => {
+		ora({interval: 0});
+	}, {message: /positive integer/});
+});
+
+test('color rejects invalid color names', () => {
+	assert.throws(() => {
+		ora({color: 'invalid'});
+	}, {message: /valid color/});
+});
+
+test('color rejects non-string non-false values', () => {
+	assert.throws(() => {
+		ora({color: 123});
+	}, {message: /valid color/});
+});
+
+test('color accepts false to disable', () => {
+	const spinner = ora({color: false, isEnabled: false});
+	assert.strictEqual(spinner.color, false);
+});
+
+test('color accepts valid color names', () => {
+	const spinner = ora({color: 'red', isEnabled: false});
+	assert.strictEqual(spinner.color, 'red');
+});
+
+test('color accepts undefined', () => {
+	const spinner = ora({color: undefined, isEnabled: false});
+	assert.strictEqual(spinner.color, undefined);
+});
+
+test('color setter accepts undefined', () => {
+	const spinner = ora({color: 'green', isEnabled: false});
+	spinner.color = undefined;
+	assert.strictEqual(spinner.color, undefined);
+});
+
 test('text setter handles falsy values correctly', () => {
 	const spinner = ora({color: false});
 	spinner.text = null;